Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix %%graph_notebook_config error when excluding optional Gremlin section #633

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

michaelnchin
Copy link
Member

Issue #, if available: #632

Description of changes:

  • Fixed an issue where setting %%graph_notebook_config for non-Neptune hosts would fail unless the optional gremlin sub-section was included in the JSON.
  • Added unit tests to validate required/optional/allowed fields for get_config.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@michaelnchin michaelnchin marked this pull request as ready for review June 25, 2024 05:59
@michaelnchin michaelnchin merged commit 572ef94 into main Jun 25, 2024
3 checks passed
@michaelnchin michaelnchin deleted the Issue-632 branch June 25, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

[BUG] %%graph_notebook_config sometimes fails when Gremlin section is excluded
1 participant