Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendoring and fix xnet patch to reflect for CCM #3133

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

rcrozean
Copy link
Member

Issue #, if available:

Description of changes:
We don't need to vendor ccm to fix xnet in CCM. Regenerating patch 0002 to only patch go.mod and go.sum and remove the patch 0001 which only added the vendor folder to ccm.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added patch Pull request that add .patch files v1.26 v1.27 v1.28 v1.29 and removed size/XXL labels Jun 19, 2024
@wongma7
Copy link
Member

wongma7 commented Jun 19, 2024

/lgtm

@rcrozean
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rcrozean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit bcc9caf into aws:main Jun 19, 2024
5 of 6 checks passed
@rcrozean rcrozean deleted the simplifyCCMXnetPatch branch June 20, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants