Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing configuration options to fluentbit chart #758

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nwsparks
Copy link

@nwsparks nwsparks commented May 17, 2022

Issue

n/a

Description of changes

Adds a few missing options from the cloudwatch plugin to the fluentbit chart, see https://github.com/aws/amazon-cloudwatch-logs-for-fluent-bit#plugin-options

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

helm lint passed
helm template fluentbit . --set cloudWatch.defaultLogGroupName=test --set cloudWatch.defaultLogStreamName=test --set cloudWatch.newLogGroupTags="tag1=test\,tag2=test" --validate helm template passed
helm install fluentbit . --set cloudWatch.defaultLogGroupName=test --set cloudWatch.defaultLogStreamName=test --set cloudWatch.newLogGroupTags="tag1=test\,tag2=test" installed and verified in the config map the the desired configurations were present.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant