Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-for-fluent-bit] Make it possible to overwrite the used ES index-name #599

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[aws-for-fluent-bit] Make it possible to overwrite the used ES index-name #599

wants to merge 6 commits into from

Conversation

Alien2150
Copy link

@Alien2150 Alien2150 commented Sep 10, 2021 •
edited
Loading

Description of changes

Make it possible to overwrite the index that Elasticsearch is writing to. Right now it always puts the documents to the "fluent-bit" index: https://docs.fluentbit.io/manual/pipeline/outputs/elasticsearch

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

  • Set indexName to some value like "weblogs-00001".
  • Output for ES will be written to weblogs-00001

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Alien2150 Alien2150 changed the title [aws-for-fluent-bit] Make it possible to overwrite index [aws-for-fluent-bit] Make it possible to overwrite the used ES index-name Sep 10, 2021
@Alien2150 Alien2150 changed the title [aws-for-fluent-bit] Make it possible to overwrite the used ES index-name [aws-for-fluent-bit] Make it possible to overwrite ES index-name Sep 10, 2021
@Alien2150 Alien2150 changed the title [aws-for-fluent-bit] Make it possible to overwrite ES index-name [aws-for-fluent-bit] Make it possible to overwrite the used ES index-name Sep 10, 2021
@Alien2150 Alien2150 marked this pull request as ready for review September 10, 2021 08:37
hossain-rayhan
hossain-rayhan reviewed Sep 10, 2021
View reviewed changes
Copy link
Contributor

@hossain-rayhan hossain-rayhan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README.

Sorry, you already did this. LGTM.

hossain-rayhan
hossain-rayhan previously approved these changes Sep 10, 2021
View reviewed changes
@Alien2150
Copy link
Author

Any chance to get it merged? @PettitWesley

PettitWesley
PettitWesley previously approved these changes Jan 7, 2022
View reviewed changes
@PettitWesley
Copy link
Contributor

@Alien2150 I prefer if one of the official maintainers of this repo would merge...

@Alien2150
Copy link
Author

@PettitWesley any chance to get it merged or what's the process to get it done? I need to adopt my index on each update and it feels just wrong :/

@Alien2150
Copy link
Author

Alien2150 commented Nov 13, 2023 •
edited
Loading

@bendu what's the process here?

@bryantbiggs bryantbiggs mentioned this pull request Oct 3, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hossain-rayhan hossain-rayhan hossain-rayhan left review comments

@PettitWesley PettitWesley PettitWesley left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alien2150 @PettitWesley @hossain-rayhan