aws-cloudwatch-metrics - Add support for pod annotations #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using kube2iam for our IAM roles. This requires adding an annotation to each pod to allow it to assume the required role.
hintofbasil
requested review from
bwagner5,
jaypipes and
kishorj
as code owners
apham0001
approved these changes
Nov 22, 2021
apham0001
reviewed
Nov 22, 2021
| @@ -12,6 +12,10 @@ spec: | |||
| metadata: | |||
| labels: | |||
| {{- include "aws-cloudwatch-metrics.selectorLabels" . | nindent 8 }} | |||
| {{- if .Values.podAnnotations }} | |||
There was a problem hiding this comment.
as annotations exist on aws-for-fluent-bit chart. Maybe we should harmonize the variable
{{- if .Values.annotations }}
| @@ -12,6 +12,10 @@ spec: | |||
| metadata: | |||
| labels: | |||
| {{- include "aws-cloudwatch-metrics.selectorLabels" . | nindent 8 }} | |||
| {{- if .Values.podAnnotations }} | |||
| annotations: | |||
| {{- toYaml .Values.podAnnotations | nindent 8 }} | |||
There was a problem hiding this comment.
as annotations exist on aws-for-fluent-bit chart. Maybe we should harmonize the variable
{{- toYaml .Values.podAnnotations | nindent 8 }}
| @@ -18,3 +18,5 @@ serviceAccount: | |||
| name: | |||
|
|
|||
| hostNetwork: false | |||
|
|
|||
| podAnnotations: {} | |||
| | `serviceAccount.create` | Whether a new service account should be created | `true` | | ||
| | `serviceAccount.name` | Service account to be used | | | ||
| | `hostNetwork` | Allow to use the network namespace and network resources of the node | `false` | | ||
| | `podAnnotations` | Annotations to add to each pod | {} | |
There was a problem hiding this comment.
| annotations | Optional pod annotations | {} |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
We are using kube2iam for our IAM roles. This requires adding an annotation to
each pod to allow it to assume the required role.
Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
Templated the chart with various values including no
podAnnotationsvalue,podAnnotations: {}and valid annotations. Templated output was not run against a cluster but visually verified.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.