Added Replace_Dots option to fluent-bit Elasticsearch output defaulti… #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonumiker I squash-merged #353 this morning. Apologies for the delay and thank you for your patience. This PR can now be closed. |
|
@jasonumiker Apologies again! I did not realize until just now that #353 only referred to the kinesis config section and not the Elasticsearch section, which you PR and #362 refer to. Reopening this. Le sigh, sorry about this... |
|
@jasonumiker @dpujadas OK, this is now merged (with chart version 0.1.11. I manually resolved the conflicts in this PR that resulted in me merging #353. Apologies for all the confusion and annoyances to you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an existing approved pull request that you are having trouble merging because another PR got in and took the Helm chart version number - #362
I just recreated that incrementing the version number again - so this one should be mergable...