Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-for-fluent-bit: Add the ability to add annotations to the daemonset #417

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

georgyo
Copy link

@georgyo georgyo commented Jan 9, 2021

Issue #, if available:

Description of changes:
The current chart explicitly requires using the host's metadata credentials to talk to cloudhealth. This means that that you cannot block that metadata access for any of your pods or use a solution like kiam.

This chart requires the ability to add annotations like iam.amazonaws.com/role or eks.amazonaws.com/role-arn to allow the use of solutions that provide correct credentials to these pods.

Alternatively, the chart could allow using the host networking, but I much rather it support it using the correct role provided by a solution like kiam.

Copy link
Contributor

@PettitWesley PettitWesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing annotations seems like an unobjectionable change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants