Add automatic creation of ENIConfig's #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayanthvn
approved these changes
Jan 7, 2021
|
@Kent1 can you please resolve the conflicts to move this forward |
|
done |
|
Waiting for this to be merged :) |
|
Thanks for your contribution. We recently added this [1] PR template to help guide on what changes need to be made as part of the pull requests (README, chart version increment etc). The change is good to merge once the PR checklist is updated [1] https://github.com/aws/eks-charts/blob/master/.github/PULL_REQUEST_TEMPLATE.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the creation of the ENIConfig to Helm. That allows to pass, for example in our case, the created subnets and SGs from terraform and pass them to Helm.
I used availability zone for the name of ENIConfig as recommanded in the doc.