Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding chart for aws-for-fluent-bit #104

Merged
merged 7 commits into from
May 7, 2020
Merged

Conversation

mforutan
Copy link
Contributor

@mforutan mforutan commented Apr 8, 2020

Signed-off-by: Mohammad Forutan [email protected]

Closes #101

Description of changes:

Adding a new chart for aws-for-fluent-bit

@mforutan
Copy link
Contributor Author

mforutan commented Apr 10, 2020

@max-rocket-internet, do you know what I should do for CircleCI test which is failing?

@max-rocket-internet
Copy link
Contributor

Hmmm not sure: fatal: Path 'stable/aws-for-fluent-bit/Chart.yaml' exists on disk, but not in '2ddfdaed9848dab80a67de33ee02d070a566a2f3'.

Will need a maintainer from here to look at it.

@bwagner5
Copy link
Collaborator

@mforutan This is a recent test addition to make sure chart versions are incremented before release. Since this is a new chart, it doesn't exist in the last release. I'll update the test today to fix this bug.

@bwagner5
Copy link
Collaborator

Here's the PR to fix the test: #105

@joesteffee
Copy link

This is still erroring on the chart version for appmesh-controller. I think we can solve this a couple of ways, force a refresh and re-run of circleCI or just bump the app version in this PR so it stops complaining.

@bwagner5
Copy link
Collaborator

@joesteffee sorry about the problems with this new test. I submitted a PR to fix this case as well. #110

@mforutan
Copy link
Contributor Author

@max-rocket-internet @bwagner5, now this is ready for review, thanks

@mforutan
Copy link
Contributor Author

mforutan commented May 7, 2020

@max-rocket-internet @bwagner5, is there anything that I can do to speed up the process here?

Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very tidy indeed, @mforutan, great job! :)

Merging this now and cutting a release of the EKS charts repo shortly.

Thanks!
-jay

@jaypipes jaypipes merged commit a73b2a3 into aws:master May 7, 2020
@mforutan mforutan deleted the fix-101 branch May 9, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS for FluentBit helm chart
5 participants