-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding chart for aws-for-fluent-bit #104
Conversation
Signed-off-by: Mohammad Forutan <[email protected]>
Signed-off-by: Mohammad Forutan <[email protected]>
@max-rocket-internet, do you know what I should do for CircleCI test which is failing? |
Hmmm not sure: Will need a maintainer from here to look at it. |
@mforutan This is a recent test addition to make sure chart versions are incremented before release. Since this is a new chart, it doesn't exist in the last release. I'll update the test today to fix this bug. |
Here's the PR to fix the test: #105 |
Signed-off-by: Mohammad Forutan <[email protected]>
This is still erroring on the chart version for appmesh-controller. I think we can solve this a couple of ways, force a refresh and re-run of circleCI or just bump the app version in this PR so it stops complaining. |
@joesteffee sorry about the problems with this new test. I submitted a PR to fix this case as well. #110 |
Signed-off-by: Mohammad Forutan <[email protected]>
@max-rocket-internet @bwagner5, now this is ready for review, thanks |
@max-rocket-internet @bwagner5, is there anything that I can do to speed up the process here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very tidy indeed, @mforutan, great job! :)
Merging this now and cutting a release of the EKS charts repo shortly.
Thanks!
-jay
Signed-off-by: Mohammad Forutan [email protected]
Closes #101
Description of changes:
Adding a new chart for aws-for-fluent-bit