Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.20] Remove "max-instances" from e2e binary #8897

Merged

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Oct 24, 2024

Description of changes:
This is a manual cherry-pick of #8887.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 24, 2024
@rahulbabu95
Copy link
Member

/retest

Signed-off-by: Rahul Ganesh <[email protected]>
Co-authored-by: Rahul Ganesh <[email protected]>
@sp1999 sp1999 force-pushed the cherry-pick-8887-to-release-0.20 branch from afc7a68 to d287292 Compare October 24, 2024 20:03
@sp1999
Copy link
Member Author

sp1999 commented Oct 24, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhaanvi5
Copy link
Member

/lgtm

@sp1999
Copy link
Member Author

sp1999 commented Oct 24, 2024

Presubmits failed earlier because #8264 and #8627 weren't backported

@eks-distro-bot eks-distro-bot merged commit 99c7554 into aws:release-0.20 Oct 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants