-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose CLI flag to tell Smee (Boots) on which interface to bind #8760
base: main
Are you sure you want to change the base?
Conversation
The flag let's the user configure the network interface on which smee (boots) service will bind it's services
Hi @Gedulis12. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey @Gedulis12 , thanks for this contribution! If i understand what you're wanting, this functionality already exists with the flag |
Hi @jacobweinstock , thanks for the response. I have tested it before raising this PR, unfortunately |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ah, i see from your PR that it looks like it's not the binding to an interface thats a problem but the IP used in DHCP packets for syslog, tftp, http, etc. As you've found, we're not setting the appropriate CLI flags for Smee in order for network booting to happen properly. The |
@jacobweinstock Thanks for the feedback. I will work on amendment for the PR so that the functionality lands in |
Issue #, if available:
Description of changes:
Added a cli flag option
--smee-bind-ip
, which tells smee service on which interface to bind it's services for serving pxe boot binaries (http, tftp etc..)Currently EKS-A uses the default smee behaviour, which binds it's services on the first available hosts public interface. This causes an issue with the admin host if it is using multiple interfaces, as the "first" interface in the list is not necessarily the the one that's intended to be used as EKS-A network.
Testing (if applicable):
Added a test case for TestTinkerbellStackInstallWithDifferentOptions in
pkg/providers/tinkerbell/stack/stack_test.go
which checks thedocker run
command for boots service.Additionally added validations in SetupAndValidateCreateCluster() which checks if the provided IP is valid and bound to any network interface on the host.
All unit tests pass.
Documentation added/planned (if applicable):
Updated
docs/content/en/docs/reference/eksctl/anywhere_create_cluster.md
with the new CLI optionBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.