Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add instructions for generating support bundle when using a private authenticated registry #8069

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RobertNorthard
Copy link
Contributor

…vate registry which is authenticated

Issue #, if available:
N/A

Description of changes:
Added instructions for generating a support bundle when using a private authenticated registry

Testing (if applicable):
N/A

Documentation added/planned (if applicable):
Added instructions for generating a support bundle when using a private authenticated registr

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csplinter for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot
Copy link
Collaborator

Hi @RobertNorthard. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.44%. Comparing base (0a9a495) to head (e47fa6c).
Report is 359 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8069      +/-   ##
==========================================
- Coverage   73.44%   73.44%   -0.01%     
==========================================
  Files         577      577              
  Lines       35878    35878              
==========================================
- Hits        26351    26349       -2     
- Misses       7861     7862       +1     
- Partials     1666     1667       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999
Copy link
Member

sp1999 commented Oct 24, 2024

/ok-to-test

@sp1999
Copy link
Member

sp1999 commented Oct 24, 2024

Did you verify locally that the support bundle gets generated after setting those env variables? What errors did you get when generating the support bundle without those env variables? It would be good to have that information in the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation documentation ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants