Skip cert validator unit test for darwin #3262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/XS
vivek-koppuru
force-pushed
the
skip-cert-test
branch
from
143a061 to
13c1ae3
Compare
Codecov Report
@@ Coverage Diff @@
## main #3262 +/- ##
==========================================
+ Coverage 64.06% 64.17% +0.10%
==========================================
Files 348 348
Lines 27605 27688 +83
==========================================
+ Hits 17685 17768 +83
Misses 8615 8615
Partials 1305 1305
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vivek-koppuru The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vivek-koppuru
force-pushed
the
skip-cert-test
branch
from
13c1ae3 to
eed44a6
Compare
vivek-koppuru
force-pushed
the
skip-cert-test
branch
from
eed44a6 to
c38006a
Compare
eks-distro-bot
added
size/S
|
/LGTM |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We need to add this check as newer version of macos require the adding trusted certs manually,
through
security add-trusted-cert, so we are only able to run this test on linux for now. This is a known issue here: golang/go#52010Created #3267 to track our fix for the above issue
Refer to https://go-review.googlesource.com/c/go/+/353132 and helm/helm#11160 for some explanations and an example
Testing (if applicable):
unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.