Add patch for CAPI CRS Reconcile mode #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/XXL
jonathanmeier5
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
lgtm
Failing on checksums, but I think if we merge there's a job that should automatically update them like in this automated PR.
|
No, you cant merge this without updating the checksum. That above job is to catch the case where we legitimately updated golang in the builder base. |
g-gaston
force-pushed
the
eks-a-crs-reconcile
branch
from
fa3685c to
713788b
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: g-gaston The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds the
Reconcilemode forClusterResourceSetsUpstream PR: kubernetes-sigs/cluster-api#7497
Design: kubernetes-sigs/cluster-api#6555
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.