Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update tag flag description #5004

Merged
merged 4 commits into from
Jun 20, 2023
Merged

docs: update tag flag description #5004

merged 4 commits into from
Jun 20, 2023

Conversation

iamhopaul123
Copy link
Contributor

Resolves #4973

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@iamhopaul123 iamhopaul123 requested review from hkford and a team as code owners June 16, 2023 23:06
@iamhopaul123 iamhopaul123 requested review from KollaAdithya and removed request for a team June 16, 2023 23:06
@github-actions
Copy link

github-actions bot commented Jun 16, 2023 •
edited
Loading

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 50916 50748 +0.33
macOS (arm) 51104 50956 +0.29
linux (amd) 44824 44680 +0.32
linux (arm) 43076 43012 +0.15
windows (amd) 41676 41548 +0.31

@codecov-commenter
Copy link

Codecov Report

Merging #5004 (e6fd092) into mainline (b1d15dd) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           mainline    #5004   +/-   ##
=========================================
  Coverage     70.16%   70.16%           
=========================================
  Files           289      289           
  Lines         41808    41811    +3     
  Branches        285      285           
=========================================
+ Hits          29335    29338    +3     
  Misses        11060    11060           
  Partials       1413     1413

see 1 file with indirect coverage changes

huanjani
huanjani reviewed Jun 19, 2023
View reviewed changes
internal/pkg/cli/flag.go Outdated Show resolved Hide resolved
huanjani
huanjani reviewed Jun 19, 2023
View reviewed changes
Copy link
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@huanjani
Copy link
Contributor

Related: #4983

Lou1415926
Lou1415926 approved these changes Jun 19, 2023
View reviewed changes
site/content/docs/commands/deploy.en.md Outdated Show resolved Hide resolved
dannyrandall
dannyrandall requested changes Jun 20, 2023
View reviewed changes
internal/pkg/cli/flag.go Outdated Show resolved Hide resolved
@dannyrandall dannyrandall added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jun 20, 2023
@iamhopaul123 iamhopaul123 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jun 20, 2023
@mergify mergify bot merged commit ad52ae5 into aws:mainline Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huanjani huanjani huanjani left review comments

@Lou1415926 Lou1415926 Lou1415926 approved these changes

@dannyrandall dannyrandall dannyrandall approved these changes

@hkford hkford Awaiting requested review from hkford hkford is a code owner

@KollaAdithya KollaAdithya Awaiting requested review from KollaAdithya KollaAdithya is a code owner automatically assigned from aws/aws-ecs-devx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify deploy --tag option usage
5 participants
@iamhopaul123 @codecov-commenter @huanjani @dannyrandall @Lou1415926