Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add --diff flag to pipeline deploy #4991

Merged
merged 13 commits into from
Jun 19, 2023
Merged

chore: add --diff flag to pipeline deploy #4991

merged 13 commits into from
Jun 19, 2023

Conversation

Varun359
Copy link
Contributor

Currently there is no diff flag for copilot pipeline deploy command. This PR adds that flag.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@Varun359 Varun359 requested a review from a team as a code owner June 14, 2023 16:25
@Varun359 Varun359 requested review from efekarakus and removed request for a team June 14, 2023 16:25
@github-actions
Copy link

github-actions bot commented Jun 14, 2023 •
edited
Loading

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 50904 50748 +0.31
macOS (arm) 51108 50956 +0.30
linux (amd) 44812 44680 +0.30
linux (arm) 43076 43012 +0.15
windows (amd) 41668 41548 +0.29

@Varun359 Varun359 assigned Varun359 and unassigned Varun359 Jun 15, 2023
huanjani
huanjani reviewed Jun 15, 2023
View reviewed changes
Copy link
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! 👏🏼 Great job! Nice unit tests.
Just some small nits.

internal/pkg/cli/pipeline_deploy_test.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_deploy_test.go Show resolved Hide resolved
internal/pkg/cli/pipeline_deploy.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_deploy.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023 •
edited
Loading

Codecov Report

Merging #4991 (6542468) into mainline (15ccfc6) will decrease coverage by 0.02%.
The diff coverage is 65.38%.

❗ Current head 6542468 differs from pull request most recent head d9ac759. Consider uploading reports for the commit d9ac759 to get more accurate results

@@             Coverage Diff              @@
##           mainline    #4991      +/-   ##
============================================
- Coverage     70.16%   70.15%   -0.02%     
============================================
  Files           289      289              
  Lines         41811    41856      +45     
  Branches        285      285              
============================================
+ Hits          29338    29365      +27     
- Misses        11060    11074      +14     
- Partials       1413     1417       +4
Impacted Files Coverage Δ
internal/pkg/cli/pipeline_deploy.go 56.99% <65.38%> (+0.40%) ⬆️

iamhopaul123
iamhopaul123 reviewed Jun 15, 2023
View reviewed changes
internal/pkg/cli/pipeline_deploy.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_deploy.go Outdated Show resolved Hide resolved
dannyrandall
dannyrandall reviewed Jun 15, 2023
View reviewed changes
internal/pkg/cli/pipeline_deploy.go Show resolved Hide resolved
internal/pkg/cli/pipeline_deploy.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_deploy.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_deploy.go Outdated Show resolved Hide resolved
dannyrandall
dannyrandall approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@dannyrandall dannyrandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!🎉🎉🎉 just a couple small things 😊

internal/pkg/cli/pipeline_deploy_test.go Outdated Show resolved Hide resolved
internal/pkg/cli/pipeline_deploy_test.go Outdated Show resolved Hide resolved
@dannyrandall dannyrandall added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jun 19, 2023
@Varun359 Varun359 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jun 19, 2023
@mergify mergify bot merged commit d203c09 into aws:mainline Jun 19, 2023
@dannyrandall dannyrandall mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huanjani huanjani huanjani left review comments

@iamhopaul123 iamhopaul123 iamhopaul123 approved these changes

@dannyrandall dannyrandall dannyrandall approved these changes

@efekarakus efekarakus Awaiting requested review from efekarakus efekarakus is a code owner automatically assigned from aws/aws-ecs-devx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Varun359 @codecov-commenter @dannyrandall @iamhopaul123 @huanjani