-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EKS] [request]: Allow feature gates to be set on master components #512
Comments
@jammerful hey I'm working on similar issue.... would you be able to explain your workaround a little more in-depth? What container are you deploying? |
@lanefu I'm assuming you want the volume snapshot feature, if you're trying to enable a random feature gate I don't think you can do that. |
Another good feature gate to be able to enable is |
Shouldn't the label be EKS rather than ECS? |
@ellenthsu Please remove the ECS label and add the EKS label. |
Apparently alpha feature gates are not enabled on the stable channels of AKS or GKE, but they do have unstable channels that enable beta feature gates. Given that I don't know if AWS would consider doing this for production clusters, wish they would speak up. |
done |
I'm wanting to enable the |
I would like this feature to enable |
We're looking for |
My cx is looking to enable SCTP and it requires the SCTPSupport feature gate https://kubernetes.io/docs/concepts/services-networking/network-policies/#sctp-support |
Need to support SCTP for our telco apps too. |
I am interested in this to enable Service Topology in EKS 1.17. I am following an example to reduce cross availability zone traffic (https://v1-17.docs.kubernetes.io/docs/concepts/services-networking/service-topology/#prefer-node-local-zonal-then-regional-endpoints) which require feature-flags to be accessible: https://v1-17.docs.kubernetes.io/docs/tasks/administer-cluster/enabling-service-topology/#enable-service-topology |
@mikeaorlando something that I discovered..... If you're using terraform modules, it's easy to switch from EKS managed nodegroups to "worker groups". the level of config effort is about the same in terraform whether managed or unmanaged, and you can easily pass arguments for feature flags.. EX:
|
@mikeaorlando @lanefu i am also trying to use Service Topology running on EKS 1.17, i created the feature gates as @lanefu described, how can i make sure the feature is enabled? @mikeaorlando did you succeeded using the feature in EKS at all? cause every time i create/edit service with the TopologyKeys it seems to be deleted after saving. |
@mikeaorlando @DanOfir I am in the same boat as you wanting to use Service Topology on EKS 1.17 and find that since it has to be enabled at the API server label I'm unable to set that feature gate. |
I have been unable to use Service Topology running on EKS 1.17. My current workaround is to have all nodes in the cluster in one availability zone. This does not constrict traffic to be node-local, but reduces ingress and egress charges from cross-az traffic. My current plan is to wait until EKS 1.18. This was helpful in determining which feature flags were set in the api-server: https://docs.aws.amazon.com/eks/latest/userguide/api-server-flags.html |
In our case, we would want to set |
In our case we want to set |
Would it be possible to have a generic way to enable I'm on 1.18 and want |
Wait, AWS put out release notes specifically saying that pod topologySpreadConstraints were supported, but did not enable the feature gate?
|
@llamahunter it seems beta features are enabled by default in k8s, so the feature gate doesn't need to be passed explicitly anymore. |
@nicolai86 Have you successfully set pod topologySpreadConstraints using |
It would be nice to have PS |
Yep, |
@anton-vylushchak @s2504s @everythings-gonna-be-alright When the community elevates them to |
It would be really great if we could get |
I would like to disable a feature that is by default (beta version) enabled in EKS 1.23 |
|
@kitsirota see above #512 (comment) - the situation is the same for any feature gate in upstream. |
Agreed 💯 |
4 year anniversary and we are still there where we are |
@dims, in our company(NEXO) we use AWS EKS 1.28(managed cluster), so we wanna use feature gate |
@grglzrv see upstream issue kubernetes/enhancements#1287 - the feature will hit You can see at least 3 fixes going into You can see the list of open issues against this feature: Before you ask what it would take to make this go from alpha to beta, please see here: Presence of a feature gate does not mean it is ready by any means... you can also read about progression of feature gates in the community here: Hope this helps! |
Thanks, I appreciate your reply 🙏 |
any update? |
@dims Does EKS have a more generic feature ask to support Alpha clusters similar to GKE Alpha Clusters, where all alpha feature flags are enabled/support is best effort/no guarantees? |
I don't remember seeing one @sidewinder12s |
We are interested in |
I found myself here while trying to define the above parameter. Any update for EKS? |
Can I please get a clarification on the documentation? According to https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html
Does this mean that any feature gate added after 1.24 is disabled until it's GA? Or that EKS follows the upstream kubernetes default for whether a beta feature gate is enabled or not and before 1.24 all beta gates were enabled regardless of the default? |
Hi, we have high interest in the |
I think docs are quite clear - GA are supported and enabled, beta and thier updates - only those before 1.24 (later ones are not supported), alpha are not supported and not enabled - that is the general policy. InPlacePodVerticalScaling is denoted as alpha one so you can forget about it for now in EKS, it can be checked here: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ |
@dejwsz the docs are clear on how it currently works. This feature request is asking for it to work differently. |
Hello. I want to use InPlacePodVerticalScaling feature on my EKS cluster. EKS version is v1.27. Which version needs for it? |
@realhuseyn bruh, it is not even in beta yet, currently deferred to 1.32 ( kubernetes/enhancements#1287 ), proly 1.34 stable, thus available for EKS |
I'm here for |
Tell us about your request
I would like to be able to set feature gates on master components such as the kube-apiserver, this would allow me to enable features early.
Which service(s) is this request for?
EKS
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
Right now I can't enable feature gates on any master components, while I have a particular feature gate in mind I would like the general ability to toggle feature flags upon creating/updating a cluster. I understand that the feature gates enable alpha features, so I would simply note in the documentation and a warning upon any feature flag being set that using this feature can make your cluster unstable and all feature gates set should be throughly tested before releasing to production.
The particular feature gate is the
VolumeSnapshotDataSource
which is needed for the EBS CSI Driver's snapshotting feature.Are you currently working around this issue?
I will deploy my own container to do the snapshotting myself.
The text was updated successfully, but these errors were encountered: