-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EKS] EKS add-ons support for Amazon EBS CSI Driver #247
Comments
How is this going to work for customers that have installed the CSI driver manually? Also, is it going to manage updates automatically? |
This will be solved by a feature release following #252 |
Changing the title, as we will not be auto installing EBS CSI driver as part of cluster creation. Rather, we will add EBS CSI driver to EKS add-ons, so you can declare to have it installed as part of cluster creation through the add-ons system. |
An external CSI snapshotter with corresponding CRD, ValidatingWebhook etc. still has to be installed by customers or it is includes as well? |
It would be really useful. Currently there is, in my opinion, no clean way to deploy the CSI snapshotter with the corresponding CRDs. The only way for now is to apply the required manifests. There is not even an official helm chart to handle resources and CDRs creation. |
The EBS CSI Driver is now available in EKS add-ons in preview while we work on the following enhancements:
Check out the announcement and the documentation to get started. Feel free to leave feedback here. |
The EBS CSI driver is now available in EKS add-ons in GA! Checkout the announcement https://aws.amazon.com/about-aws/whats-new/2022/03/eks-add-ons-ebs-csi-driver-available/ |
Thank you! Great work. I must admit, I was expecting that the add-on would also take care of the role creation when oidc is enabled for the cluster. Should I create a new issue requesting for this feature? |
I have question, and I am not sure where is best way to ask it. |
@GrigorievNick The tagging feature will be implemented in AWS EBS CSI v1.6.0 and it will enable you to tag underlying EBS volumes by making use of StorageClass attributes. v1.6.0 will be eventually used for the managed EKS add-on as well , currently it uses v1.5.1 |
@youwalther65 ok, can I modify https://github.com/kubernetes-sigs/aws-ebs-csi-driver#tagging -> |
@GrigorievNick No, you can't change the container arguments for the sidecar "ebs-plugin" in managed EKS add-on because those are managed by AWS. You can verify all the managed fields owned by EKS using: For more insides please look at EKS add-on documentation and server-side apply in K8s So you either have to wait for 1.6.0 and use the StorageClass to set additional tags or use the self-managed Helm based installation where you can set them using a values.yaml which contains: |
@youwalther65 So can I propagate tags right now, some how? |
@GrigorievNick: You can propagate tags right now only using the Helm chart and modifying the controller ebs-csi container args but NOT using the managed EKS add-on. |
Thanks for help @youwalther65 . Do there is any open to community roadmap for ebs add-on on eks? |
@GrigorievNick You can raise an issued for EKS add-on on AWS public containter roadmap |
EBS CSI driver version 1.6 is now available through EKS add-ons, which supports tagging through Storage Classes. |
So right now there is no way to propagate tags through adding ebs?
чт, 21 апр. 2022 г., 09:15 Jens-Uwe Walther ***@***.***>:
… @GrigorievNick <https://github.com/GrigorievNick> No, you can't change
the container arguments for the sidecar "ebs-plugin" in managed EKS add-on
because those are managed by AWS. You can verify all the managed fields
using:
$ k get deploy -n kube-system -*-show-managed-fields* ebs-csi-controller
-o yaml
...
metadata:
...
managedFields
So you either have to wait for 1.6.0 or use the self-managed Helm based
installation where you can set them using a values.yaml which contains:
controller:
extraVolumeTags:
your-key1: your-value1
—
Reply to this email directly, view it on GitHub
<#247 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD4U5U6YVE5IMNGF4PNDAUTVGDW6PANCNFSM4HFZTRGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
For anyone that comes after; I just installed like this: module "eks_blueprints_addons" {
source = "aws-ia/eks-blueprints-addons/aws"
version = "~> 1.12.0" #ensure to update this to the latest/desired version
# Any addon from "add-ons from Amazon EKS" can be added to the below block
# https://docs.aws.amazon.com/eks/latest/userguide/eks-add-ons.html#workloads-add-ons-available-eks
eks_addons = {
aws-ebs-csi-driver = {
most_recent = true
service_account_role_arn = module.ebs_csi_driver_irsa.iam_role_arn
}
snapshot-controller = {
most_recent = true
}
}
...
} I hope this helps the next person 😄 |
EBS CSI driver installed on EKS clusters by default.
The text was updated successfully, but these errors were encountered: