Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not log Lambda runtime segments #39

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Do not log Lambda runtime segments #39

merged 1 commit into from
Dec 10, 2019

Conversation

bonybrown
Copy link
Contributor

Issue #38

Refactored the lambda_runtime_request? method and added tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bonybrown bonybrown changed the title Issue38 Do not log Lambda runtime segments Nov 25, 2019
@bonybrown bonybrown mentioned this pull request Nov 25, 2019
Closed
@srprash
Copy link
Contributor

srprash commented Dec 9, 2019

Hi @bonybrown ,
Thanks for the PR. The implementation looks correct now. However, I notice there are a few old commits included in the PR. Can you refactor to drop those commits and have only the commit for this particular change?

Thanks!

@bonybrown
Copy link
Contributor Author

Hi @srprash , I think it looks right now.

@srprash srprash merged commit 4d558d1 into aws:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srprash srprash srprash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonybrown @srprash