Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified context missing strategy default to log error #550

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

carolabadeer
Copy link
Contributor

@carolabadeer carolabadeer commented Dec 2, 2022

Issue #, if available: N/A

Description of changes: To maintain consistency across SDKs and to prevent malformed trace headers from breaking services, this PR sets the default context missing strategy to 'LOG_ERROR' instead of 'RUNTIME_ERROR'.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@carolabadeer carolabadeer requested a review from a team as a code owner December 2, 2022 22:31
Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@carolabadeer carolabadeer merged commit 801b54b into aws:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants