[aws-xray-sdk-mysql] Handle operations that return a promise instead of an event emitter (mysql2) #328
Conversation
There was a problem hiding this comment.
Awesome improvement @TuckerWhitehouse! I know that workarounds existed to support mysql2 with our existing mysql patcher, but after this change are there any further changes you think are required for complete support?
|
Hey @willarmiros - thanks! I've branch deployed with this code a couple of times just to validate things and can confirm I'm seeing xray traces for sql queries as expected. The code I'm testing with only uses Do you know how often new releases are cut or when a release with this change would be available? |
|
Awesome to hear! We can't give exact dates for releases but I will prioritize making a release with this feature in the near future. |
Issue #, if available:
https://github.com/aws/aws-xray-sdk-node/issues?q=mysql2
Description of changes:
The
mysql2package returns a promise instead of a wrapped object with an event emitter. Fortunately, the two events this package relies on (end,error) can be mapped to the promise being resolved or rejected.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.