Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqs/sns case for aws sdk v2 parameter allowlist lookups (#373) #374

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

humanzz
Copy link
Contributor

@humanzz humanzz commented Feb 24, 2023

Issue #, if available: #373

Description of changes:

  • Fix sqs/sns case SQS -> Sqs, SNS -> Sns
  • Refactor TracingInterceptorTest to
    • Make @Test cases come first
    • Move private utility methods to the end of the class
    • Extract utility methods to setup the clients for tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@humanzz humanzz requested a review from a team as a code owner February 24, 2023 19:07
@humanzz humanzz changed the title Fix sqs/sns case for parameter aws sdk v2 allowlist lookups (#373) Fix sqs/sns case for aws sdk v2 parameter allowlist lookups (#373) Feb 24, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #374 (803b9f8) into master (8215450) will increase coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #374      +/-   ##
============================================
+ Coverage     58.12%   58.26%   +0.13%     
- Complexity     1269     1272       +3     
============================================
  Files           138      138              
  Lines          5247     5247              
  Branches        633      633              
============================================
+ Hits           3050     3057       +7     
+ Misses         1902     1894       -8     
- Partials        295      296       +1     
Impacted Files Coverage Δ
...mazonaws/xray/interceptors/TracingInterceptor.java 63.34% <0.00%> (+3.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I also verified no other allowlisted services should need this change.

@willarmiros willarmiros merged commit 683898a into aws:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants