Read _X_AMZN_TRACE_ID from environment & system properties #252
Conversation
| return TraceHeader.fromString(System.getenv(LAMBDA_TRACE_HEADER_KEY)); | ||
| return TraceHeader.fromString(System.getenv(LAMBDA_TRACE_HEADER_KEY) != null | ||
| ? System.getenv(LAMBDA_TRACE_HEADER_KEY) | ||
| : System.getProperty(LAMBDA_TRACE_HEADER_KEY)); |
There was a problem hiding this comment.
Perhaps we should introduce a string that's formatted as a more idiomatic system property key, e.g. com.amazonaws.xray.traceHeader
There was a problem hiding this comment.
And also if you could link #251 in a comment in the code so we know why this behavior is different for our java SDK than in other languages.
There was a problem hiding this comment.
I can definitely do that, but I'm not clear on what you are asking for? Are you asking for this?
private static final String LAMBDA_TRACE_HEADER_PROP = "com.amazonaws.xray.traceHeader";
return TraceHeader.fromString(System.getenv(LAMBDA_TRACE_HEADER_KEY) != null
? System.getenv(LAMBDA_TRACE_HEADER_KEY)
: System.getProperty(LAMBDA_TRACE_HEADER_PROP));
There was a problem hiding this comment.
Yep exactly like that!
…ronment variable is not set
|
@willarmiros I have updated the PR with your comments. Please let me know if you need anything else changed. |
aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/contexts/LambdaSegmentContext.java
Outdated
Show resolved
Hide resolved
…ntexts/LambdaSegmentContext.java
*Issue #251
Description of changes:
For custom runtimes that use this library, IE: graalvm. It's not possible to set the _X_AMZN_TRACE_ID as a environment property. By checking the system properties for _X_AMZN_TRACE_ID, if the environment property does not exist, this will allow the X-Ray to be able to be used by custom runtimes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.