Skip to content

Commit

Permalink
Reduce log level of sampling error logging (#309)
Browse files Browse the repository at this point in the history
* Reduce log level of target poller throwables

* Update RulePoller.java

* Update RulePoller.java

* Update TargetPoller.java
  • Loading branch information
willarmiros authored Nov 12, 2021
1 parent ff57897 commit 7e93511
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public void start() {
try {
pollRule();
} catch (Throwable t) {
logger.error("Encountered error polling GetSamplingRules: ", t);
logger.info("Encountered error polling GetSamplingRules: ", t);
// Propagate if Error so executor stops executing.
// TODO(anuraaga): Many Errors aren't fatal, this should probably be more restricted, e.g.
// https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/internal/Throwables.java
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public void start() {
try {
pollManifest();
} catch (Throwable t) {
logger.error("Encountered error polling GetSamplingTargets: ", t);
logger.info("Encountered error polling GetSamplingTargets: ", t);
// Propagate if Error so executor stops executing.
// TODO(anuraaga): Many Errors aren't fatal, this should probably be more restricted, e.g.
// https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/internal/Throwables.java
Expand Down

0 comments on commit 7e93511

Please sign in to comment.