Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fatal error: concurrent map iteration and map write #457

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix fatal error: concurrent map iteration and map write #457

merged 1 commit into from
Mar 12, 2024

Conversation

wangzlei
Copy link
Contributor

Issue #, if available:

If user config StreamingStrategy to be a small value and create many AWS SDK v2 subsegments, 2 goroutines would update the Segment at the same time, causes either panic: runtime error: index out of range or fatal error: concurrent map iteration and map write.

The panic has been addressed in PR #419
The current PR is for addressing the fatal error.

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@wangzlei wangzlei requested a review from a team as a code owner March 12, 2024 18:47
Copy link
Contributor

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ty

@wangzlei wangzlei merged commit 8d69381 into aws:master Mar 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants