Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncaught error on sql url parse #121

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Fix uncaught error on sql url parse #121

merged 1 commit into from
Jun 10, 2019

Conversation

cep21
Copy link
Contributor

@cep21 cep21 commented Jun 10, 2019

If the second url.Parse fails, then u is nil and
a nil u can panic when u.User is referenced
below.

Catch any errors with url.Parse and return
them

Related to errors on #117

If the second url.Parse fails, then u is nil and
a nil u can panic when u.User is referenced
below.

Catch any errors with url.Parse and return
them
@luluzhao luluzhao merged commit b7b479f into aws:master Jun 10, 2019
@cep21 cep21 deleted the fix_sql_bug branch June 11, 2019 00:29
@luluzhao luluzhao mentioned this pull request Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants