telemetry(amazonq): Improving error handling and telemetry in unit test generation #6386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ashishrp-aws
changed the title
ashishrp-aws
changed the title
justinmk3
reviewed
Jan 17, 2025
There was a problem hiding this comment.
For reference: as mentioned in #6187 (comment) , this module is not a recommended pattern. Mirroring every single service error manually is a maintenance burden, and doesn't make sense. Either the generated SDK should do this or we should find a programmatic solution.
There was a problem hiding this comment.
Agreed....we are working on error handling on service side of things. Once those changes are ready. we will make changes here on plugin. But yes, essentially we will get proper errors from the service.
justinmk3
approved these changes
Jan 17, 2025
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
## Problem Incorrect handling of errors for 4xx and 5xx on IDE. Proper error messages for users and telemetry needs to differentiate between service errors. ## Solution - Adding 4XX vs 5XX `httpStatusCode` field to `amazonq_utgGenerateTests` event. - Improving error handling in unit test generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Incorrect handling of errors for 4xx and 5xx on IDE. Proper error messages for users and telemetry needs to differentiate between service errors.
Solution
Copy of @laileni-aws's: telemetry(amazonq): Improving error handling and telemetry in unit test generation. #6187. CLosed 6187 due to rebasing issues and lack of permissions.
httpStatusCodefield toamazonq_utgGenerateTestsevent.feature/xbranches will not be squash-merged at release time.