fix(amazonq): User can view file diff by file click #6383
Merged
+42
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hayemaxi
reviewed
Jan 16, 2025
| @@ -35,6 +36,7 @@ export interface MessageData { | |||
| } | |||
| // TODO: Refactor testChatConnector, scanChatConnector and other apps connector files post RIV | |||
| export class Connector extends BaseConnector { | |||
| connector: any | |||
There was a problem hiding this comment.
What is this? Looks unused.
hayemaxi
reviewed
Jan 16, 2025
| messageId, | ||
| tabType: 'testgen', | ||
| }) | ||
| this.onChatAnswerReceived?.( |
There was a problem hiding this comment.
Make the property required to remove the ?
justinmk3
reviewed
Jan 17, 2025
packages/amazonq/.changes/next-release/Bug Fix-34e877a1-d2ca-4c93-9dee-5dd2019769fe.json
Outdated
Show resolved
Hide resolved
hayemaxi
approved these changes
Jan 17, 2025
ctlai95
approved these changes
Jan 17, 2025
ashishrp-aws
approved these changes
Jan 17, 2025
…c93-9dee-5dd2019769fe.json update Changelog to mention the particular command Co-authored-by: Justin M. Keyes <[email protected]>
dogusata
reviewed
Jan 17, 2025
dogusata
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
User can only view file diff by clicking the viewdiff button. This fix allows user view the file diff by clicking the file in file tree and update UI accordingly.
Screen.Recording.2025-01-16.at.12.57.17.PM.mov
Solution
Update the onFileDiff function on testChatConnector. Send the file diff open request there and implement the onChatAnswerReceived function to handle the followup functionality.
feature/xbranches will not be squash-merged at release time.