Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integ/test: --disable-workspace-trust #1821

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Conversation

JadenSimon
Copy link
Contributor

@JadenSimon JadenSimon commented Jun 21, 2021

VS code 1.57 introduced a 'trust' feature that is applied to the current workspace, restricting extension access based on trust level. The insiders build allows individual extensions to have a trust level, by default they are untrusted. Untrusted extensions cannot be activated, thus failing the test. We are not particularly concerned with this functionality in regards to other extensions, so we will just disable it entirely when testing.

We should look into this more for our own extension as far as UX is concerned (what should our extension be capable of given a minimum trust level?)

Refer to this issue: microsoft/vscode#120251

Considerations for the toolkit (to be added to package.json):

capabilities:
	untrustedWorkspaces:
		{ supported: true } |
		{ supported: false, description: string } |
		{ supported: 'limited', description: string, restrictedConfigurations?: string[] }

By default, extensions do not support untrusted workspaces. This seems to be the best option for the toolkit for now. In other words, we do not need to update anything unless we want to add a description string for why we do not support untrusted workspaces.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@JadenSimon
Copy link
Contributor Author

/runintegrationtests

@JadenSimon JadenSimon marked this pull request as ready for review June 21, 2021 18:18
@JadenSimon JadenSimon requested a review from a team as a code owner June 21, 2021 18:18
@JadenSimon
Copy link
Contributor Author

Failed stable test is unrelated.

@bryceitoc9
Copy link
Contributor

/retrybuilds

@justinmk3 justinmk3 changed the title integ/test: fix insiders integ/test: --disable-workspace-trust Jun 21, 2021
@justinmk3 justinmk3 merged commit f6b843b into master Jun 21, 2021
@justinmk3 justinmk3 deleted the sijaden/insidersfix branch June 21, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants