Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit all documents before resolving event input if it is a file #974

Merged
merged 2 commits into from
May 20, 2019

Conversation

abrooksv
Copy link
Contributor

@abrooksv abrooksv commented May 17, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Motivation and Context

Related Issue(s)

#910

Testing

Manual testing and new unit test

Screenshots (if appropriate)

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • Local run of gradlew check succeeds
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@abrooksv abrooksv requested a review from a team as a code owner May 17, 2019 22:12
@codecov-io
Copy link

codecov-io commented May 17, 2019

Codecov Report

Merging #974 into master will decrease coverage by 8.26%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #974      +/-   ##
============================================
- Coverage     52.74%   44.48%   -8.27%     
+ Complexity      551      482      -69     
============================================
  Files           162      162              
  Lines          5318     5319       +1     
  Branches        667      667              
============================================
- Hits           2805     2366     -439     
- Misses         2254     2729     +475     
+ Partials        259      224      -35
Flag Coverage Δ Complexity Δ
#integtest ? ?
#unittest 44.48% <100%> (+0.01%) 482 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...ces/lambda/execution/LambdaRunConfigurationBase.kt 73.58% <100%> (+0.5%) 16 <0> (ø) ⬇️
...e/src/software/aws/toolkits/core/s3/BucketUtils.kt 0% <0%> (-100%) 0% <0%> (ø)
...ns/services/lambda/python/PythonSamDebugSupport.kt 0% <0%> (-96.97%) 0% <0%> (-3%)
...ains/services/lambda/python/PythonLambdaBuilder.kt 0% <0%> (-84.62%) 0% <0%> (-4%)
...etbrains/services/lambda/deploy/SamDeployDialog.kt 0% <0%> (-82.31%) 0% <0%> (-16%)
...etbrains/services/lambda/deploy/SamDeployView.java 0% <0%> (-79.49%) 0% <0%> (-5%)
...ins/services/lambda/execution/local/SamDebugger.kt 0% <0%> (-75%) 0% <0%> (-4%)
...rains/services/lambda/execution/local/SamRunner.kt 25% <0%> (-75%) 1% <0%> (-2%)
...services/lambda/execution/local/SamRunningState.kt 12.5% <0%> (-68.75%) 2% <0%> (-6%)
...etbrains/services/lambda/java/JavaLambdaBuilder.kt 5.26% <0%> (-68.43%) 1% <0%> (-7%)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6697cd0...ed1ac68. Read the comment docs.

@abrooksv abrooksv merged commit 890c69b into master May 20, 2019
@abrooksv abrooksv deleted the abrooksv-commitInputFile branch May 20, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants