Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert open and close sign in webview telemetry #4850

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

manodnyab
Copy link
Contributor

Types of changes

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Fix for : #4849

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@manodnyab manodnyab requested a review from a team as a code owner August 30, 2024 17:53
@rli
Copy link
Contributor

rli commented Aug 30, 2024

changelog

@manodnyab manodnyab requested a review from a team as a code owner August 30, 2024 18:13
@manodnyab manodnyab merged commit 225938d into main Aug 30, 2024
1 of 8 checks passed
@manodnyab manodnyab deleted the manodnyb/revertqtelemetryonopnechat branch August 30, 2024 18:38
Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

bweedop pushed a commit to bweedop/aws-toolkit-jetbrains that referenced this pull request Sep 4, 2024
* Revert open and close sign in webview telemetry

* add changelog

* added issue in changelog

* Update bugfix-64bb0c4b-8d3b-45b0-b615-8722bb3e9e4a.json

---------

Co-authored-by: Richard Li <[email protected]>
bweedop added a commit that referenced this pull request Oct 1, 2024
…4869)

* feat (Amazon Q): Add basic UX and logic for generating unit tests

* Update cwspr model with GENERATE_UNIT_TESTS user intent

* fix (Amazon Q): Pass context specific intent and trigger type to chat (#4842)

* Added authType to loginWithBrowser metric (#4843)

* Added authType to loginWithBrowser metric

* Add open and close sign in metrics

* detekt

* addressed feedback

* feedback

* moved the util function

* Added UI click metrics on all login options (#4838)

* Added UI click metrics on all login options

* Combined calls for continue and back button

* Updating version to 3.25

* Updating SNAPSHOT version to 3.26-SNAPSHOT

* Revert open and close sign in webview telemetry (#4850)

* Revert open and close sign in webview telemetry

* add changelog

* added issue in changelog

* Update bugfix-64bb0c4b-8d3b-45b0-b615-8722bb3e9e4a.json

---------

Co-authored-by: Richard Li <[email protected]>

* Updating version to 3.26

* Updating SNAPSHOT version to 3.27-SNAPSHOT

* telemetry(amazonq): update telemetry (#4847)

* telemetry(amazonq): update telemetry

* remove unused import

---------

Co-authored-by: David Hasani <[email protected]>

* feat(amazonq): Reduce @workspace indexing time by 50% (#4846)

* Hash startUrl

* Revert CodeWhisperer endpoint back gamma endpoint

* Revert adding user intent to interact with message metadata

* Add changelog

* Refactor for consistent hashing of startUrl

* Remove hashing logic on startUrl and changelog entry

* Add (Beta) suffix to generate unit tests command

* Add check for startUrl when getting user intent from prompt

* Update TestCodeAction to resolve lint failure

Co-authored-by: Richard Li <[email protected]>

* address comments: Better GenerateUnitTest Action naming

* Refactor to use more specific command for UTG

* Change name of action to GenerateUnitTests

* Fix linting errors

* Override 'getActionUpdateThread'

* Reorder MessageBundle.properties

* Fix syntax error

---------

Co-authored-by: manodnyab <[email protected]>
Co-authored-by: aws-toolkit-automation <>
Co-authored-by: Richard Li <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David Hasani <[email protected]>
Co-authored-by: Lei Gao <[email protected]>
Co-authored-by: David Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants