Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Null Pointer Exception error in the editor created event. #4562

Merged
merged 8 commits into from
Jun 7, 2024
Merged

Fix for Null Pointer Exception error in the editor created event. #4562

merged 8 commits into from
Jun 7, 2024

Conversation

ashishrp-aws
Copy link
Contributor

@ashishrp-aws ashishrp-aws commented Jun 7, 2024 •
edited by rli
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

#4554
Fix for Null Pointer Exception error in the editor created event check.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashishrp-aws ashishrp-aws requested a review from a team as a code owner June 7, 2024 17:01
@ashishrp-aws ashishrp-aws changed the title Fix for Null Pointer Exception error in the editor created event check. Fix for Null Pointer Exception error in the editor created event. Jun 7, 2024
@ashishrp-aws ashishrp-aws requested a review from a team as a code owner June 7, 2024 17:04
rli
rli approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@rli rli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please determine if outstanding comments are nonblocking or can be addressed later, and have an item to fast-follow with a test case for the issue being fixed

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rli rli merged commit 8761d5d into aws:main Jun 7, 2024
9 of 11 checks passed
@ashishrp-aws ashishrp-aws deleted the file-event-fix branch June 7, 2024 20:58
@ashishrp-aws ashishrp-aws restored the file-event-fix branch June 7, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Will-ShaoHua Will-ShaoHua Will-ShaoHua approved these changes

@rli rli rli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashishrp-aws @rli @Will-ShaoHua