feat: Adds support for Placeholders in TrainingStep to set S3 location for InputDataConfig and OutputDataConfig #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…propagate to Estimator
wong-a
reviewed
Jun 11, 2021
ca-nguyen
changed the title
…ining step creation with placeholders
ca-nguyen
changed the title
wong-a
reviewed
Jun 16, 2021
wong-a
requested changes
Jun 16, 2021
wong-a
reviewed
Jun 17, 2021
wong-a
requested changes
Jun 17, 2021
wong-a
changed the title
wong-a
requested changes
Jun 17, 2021
Co-authored-by: Adam Wong <[email protected]>
…ub.com/ca-nguyen/aws-step-functions-data-science-sdk-python into training-step-with-dynamic-output-path
…emoved unused imports
wong-a
reviewed
Jun 18, 2021
ca-nguyen
commented
Jun 18, 2021
src/stepfunctions/steps/sagemaker.py
Outdated
| @@ -15,7 +15,9 @@ | |||
| import logging | |||
|
|
|||
| from enum import Enum | |||
| from stepfunctions.inputs import ExecutionInput, StepInput | |||
| import logging | |||
There was a problem hiding this comment.
To be removed in next commit
wong-a
approved these changes
Jun 18, 2021
shivlaks
approved these changes
Jun 18, 2021
shivlaks
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This was referenced Jun 19, 2021
shivlaks
added a commit
that referenced
this pull request
Jun 21, 2021
bump for `v2.2.0` which includes the following changes: Features * Placeholders in TrainingStep to set S3 location for InputDataConfig and OutputDataConfig (#142) * EventBridge service integration (#147) Fixes * supplying hyperparameters to training step constructor drops hyperparameters specified in estimator (#144)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #98, #97, #80
Description of changes:
Currently, it is not possible to specify the output path to TrainingStep. It needs to be defined at the Estimator level, which does not support placeholders. This change will make it possible to insert a placeholder output path from the TrainingStep definition and propagate it dynamically to the Estimator.
This change change also makes the TrainingStep data parameter compatible with placeholders.
There are other feature requests to make other TrainingStep arguments and ProcessingStep arguments compatible with placeholders. They will be addressed in a separate PR where the implementation could maybe be done at a higher level to avoid repetition.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.