Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Enumerable::Enumerator with Enumerator #1739

Merged
merged 5 commits into from
Mar 29, 2018
Merged

Conversation

david-a
Copy link
Contributor

@david-a david-a commented Mar 26, 2018

Fixes the error undefined method each for Enumerable::Enumerator
This occurs where there's another Enumerable module defined in the environment, and it has an Enumerator class defined without each and next methods.

Issue: #1738

fixes the error `undefined method each for Enumerable::Enumerator`
@awood45
Copy link
Member

awood45 commented Mar 26, 2018

Is it possible for you to add a (previously) failing test to the spec suite that reflects the error?

It otherwise looks good, and happy to help if you're not sure about the best way to do this.

@david-a
Copy link
Contributor Author

david-a commented Mar 26, 2018

Sure, I'll look into it later today.
Thanks for your quick response!

@david-a
Copy link
Contributor Author

david-a commented Mar 27, 2018

@awood45 done :)
I've looked deeper into it, and this issue occurs only in environments which have another Enumerable module defined, and this module has an Enumerator class defined without each and next methods.
Somehow my environment has this module, and I know it may be an edge case, but it won't hurt to add those :: as a precaution.

@david-a
Copy link
Contributor Author

david-a commented Mar 28, 2018

Just want to update, I've found the cause for the problematic (empty) definition of Enumerable::Enumerator in my environment - for me it was the gem CFPropertyList-rails (v1.0.2) which uses an old version of CFPropertyList (v2.2.8).

@cjyclaire
Copy link
Contributor

Thanks! Could you also add a changelog entry here, such that your changes can be included in the next release of aws-sdk-core gem?

@david-a
Copy link
Contributor Author

david-a commented Mar 29, 2018

@cjyclaire sure, under what version number?

@cjyclaire
Copy link
Contributor

Under "unreleased changes" section is fine, just follow the format to add an entry. Our build tools will auto bump the version in the next release : )

@david-a
Copy link
Contributor Author

david-a commented Mar 29, 2018

@cjyclaire done, I hope it's ok now

@cjyclaire cjyclaire merged commit f1eb797 into aws:master Mar 29, 2018
@cjyclaire
Copy link
Contributor

Thanks for the contribution! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants