PHP 8.0, 8.1, PHPUnit 9 support + automated check for php compatibility #2403

Zombaya · 2022-03-18T11:05:29Z

I've expanded on the excellent work done by @27pchrisl in PR #2332. I rebased his branch onto the latest version of master, upgraded the new tests to be able to use phpunit 9 and added a new CI-job that lints all code in src to make sure it is compatible with all supported versions of php (5.5-8.1) using phpcompatibility.

This should add support for php 8.0 and php 8.1 to the project and make sure no code will trigger bugs because of changes in php.

This should probably fix #2378, #2367

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Zombaya · 2022-03-18T13:04:45Z

@SamRemis , I'm pinging you since you mentioned you'd take a look at any PR's regarding usage of php 8.x in a comment on issue 2367 .

Could you please take this PR into consideration to add support for php 8.x?

stobrien89 · 2022-03-18T15:26:25Z

Hi @Zombaya and @27pchrisl,

Thanks a lot for all of the work on this. @SamRemis and I will review when we have a chance, which will take some time. We'll get back to you ASAP, likely by the end of next week.

Zombaya · 2022-03-21T09:03:34Z

Very much looking forward to it :-). If I can be of any help, please let me know and I'll try to take some time to help.

.github/workflows/tests.yml

src/MockHandler.php

.github/workflows/tests.yml

src/Crypto/AesGcmDecryptingStream.php

SamRemis · 2022-03-21T16:07:31Z

tests/Polyfill/PHPUnit4/PHPUnitCompatTrait.php

+        $this->assertContains($expected, $actual, $message);
+    }
+
+    public function assertStringNotContainsString($expected, $actual, $message = '')


This is a longer method name, I think assertStringContains() may work here?

Agreed it is long! But it's new in phpunit (https://phpunit.readthedocs.io/en/9.5/assertions.html#assertstringcontainsstring). And PhpStorm includes a linter rule to hint it should be used. However, it is certainly dealer's choice so we could revert this.

SamRemis · 2022-03-21T16:07:48Z

tests/Polyfill/PHPUnit4/PHPUnitCompatTrait.php

+        $this->assertNotContains($expected, $actual, $message);
+    }
+
+    public function assertStringContainsStringIgnoringCase($expected, $actual, $message = '')


Same as above assertStringContainsIgnoreCase()

stobrien89 · 2022-05-10T18:14:26Z

Hey @Zombaya,

I know it's been a while— sorry for the delay. Could you rebase and remove the compatibility check? We've decided it's something we'll possibly revisit in the future. Thanks again for all of the effort on this.

Zombaya · 2022-05-11T10:18:24Z

Hey @stobrien89,

I've rebased everything again, added some small fixes because of changed tests and removed the commit about php-compatibility-check.

I ran the compatibility-check manually once more before removing it and it succeeded without problems.

If you ever want to re-integrate the tool, I made a backup of the branch or you could always check the commit itself.

Zombaya · 2022-05-11T14:54:03Z

tests/ClientResolverTest.php

-        $request->expects($this->at(0))
+        $request->expects($this->exactly(2))
            ->method('getHeader')
-            ->with('X-Amz-User-Agent')
-            ->willReturn(["MockBuilder"]);
-
-        $request->expects($this->at(1))
-            ->method('withHeader')
-            ->with(
-                'X-Amz-User-Agent',
-                new \PHPUnit\Framework\Constraint\RegularExpression(
-                    '/aws-sdk-php\/' . Sdk::VERSION . '.* MockBuilder/'
-                )
-            )->willReturn($request);
-
-        $request->expects($this->at(2))
-            ->method('getHeader')
-            ->with('User-Agent')
-            ->willReturn(['MockBuilder']);
+            ->withConsecutive(
+                ['X-Amz-User-Agent'],
+                ['User-Agent']
+            )
+            ->willReturnOnConsecutiveCalls(
+                ["MockBuilder"],
+                ['MockBuilder']
+            );

-        $request->expects($this->at(3))
+        $request->expects($this->exactly(2))
            ->method('withHeader')
-            ->with(
-                'User-Agent',
-                new \PHPUnit\Framework\Constraint\RegularExpression(
-                    '/aws-sdk-php\/' . Sdk::VERSION . '.* MockBuilder/'
-                )
-            )->willReturn($request);
+            ->withConsecutive(
+                [
+                    'X-Amz-User-Agent',
+                    new \PHPUnit\Framework\Constraint\RegularExpression(
+                        '/aws-sdk-php\/' . Sdk::VERSION . '.* MockBuilder/'
+                    )
+                ],
+                [
+                    'User-Agent',
+                    new \PHPUnit\Framework\Constraint\RegularExpression(
+                        '/aws-sdk-php\/' . Sdk::VERSION . '.* MockBuilder/'
+                    )
+                ]
+            )
+            ->willReturnOnConsecutiveCalls(
+                $request,
+                $request
+            );


$this->at() is deprecated in phpunit 9 and will be removed in phpunit 10.

I've replaced the code using withConsecutive() and willReturnOnConsecutiveCalls() (Documentation).

This loses the assertion that the methods will be called in the order as specified previously, that's why I'm highlighting this change, as it might be of importance.

Zombaya · 2022-05-11T15:21:27Z

tests/Crypto/Polyfill/AesGcmTest.php

        }
-        $ptLen = \random_int(0, 1024);
-        $aadLen = \random_int(0, 1024);
-        $i = 0;
+        $ptLen = \random_int(1, 1024);
+        $aadLen = \random_int(1, 1024);


The reason the pipeline for this MR previously failed, was because $aadLen was 0, resulting in a failure when doing $aad = \random_bytes($aadLen + $i);.

This is now avoided by having the minimum-value of both lengths to be 1.

Thanks for putting in the effort to identify and correct this. I think we'll want to exclude this change for now (as annoying as this flaky test might be) since we're waiting to hear back from another team on the best path forward.

Zombaya · 2022-05-11T15:36:37Z

@stobrien89 , I'm finished for today. I believe all warnings from php 8.1 about deprecated ways of using some functions or implicit type-conversions should be fixed, as well as deprecation-warnings from phpunit 9.x and I solved the very low possibility of a failed workflow because of generating an invalid stringlength.

I believe this MR is now ready again. If you need any more changes or information, I'll be glad to help.

Zombaya · 2022-05-12T07:33:49Z

src/Credentials/AssumeRoleWithWebIdentityCredentialProvider.php

@@ -114,7 +114,7 @@ public function __invoke()
                    }
                    if (empty($token)) {
                        if ($this->tokenFileReadAttempts < $this->retries) {
-                            sleep(pow(1.2, $this->tokenFileReadAttempts));
+                            sleep((int) pow(1.2, $this->tokenFileReadAttempts));


I've kept the result of the code the same, but it does lose some precision which might be wanted.

An alternative fix would be using usleep(), to keep a higher resolution.

usleep((int) (1000*1000*pow(1.2, $this->tokenFileReadAttempts)));

(Same goes for the same change in other places where this was changed.)

I do not know if you have seen but in the file aws-sdk-php/src/Credentials/InstanceProfileProvider.php there is the same fix to do in line 262 :

private function handleRetryableException( \Exception $e, $retryOptions, $message ) { $isRetryable = true; if (!empty($status = $this->getExceptionStatusCode($e)) && isset($retryOptions['blacklist']) && in_array($status, $retryOptions['blacklist']) ) { $isRetryable = false; } if ($isRetryable && $this->attempts < $this->retries) { - sleep(pow(1.2, $this->attempts)); + sleep((int) pow(1.2, $this->attempts)); } else { throw new CredentialsException($message); } }

this patch worked for me

.changes/nextrelease/php8

stobrien89 · 2022-05-16T21:06:11Z

tests/Crypto/Polyfill/AesGcmTest.php

        }
-        $ptLen = \random_int(0, 1024);
-        $aadLen = \random_int(0, 1024);
-        $i = 0;
+        $ptLen = \random_int(1, 1024);
+        $aadLen = \random_int(1, 1024);


Thanks for putting in the effort to identify and correct this. I think we'll want to exclude this change for now (as annoying as this flaky test might be) since we're waiting to hear back from another team on the best path forward.

tests/CloudFront/fixtures/test2.pem

Zombaya · 2022-05-17T09:34:52Z

@stobrien89 , I fixed all your latest remarks and rebased everything on master once more.

However, I'm running into a new issue with the CI regarding the test Aws\Test\CloudFront\SignerTest::testBadPrivateKeyPath().

It's throwing some sort of error related to openssl, but I'm not being able to reproduce the error locally. Nor the underlying code nor the testcode have changed fundamentally with this PR, so I'm a bit out my depth here on how to fix this.

divinity76 · 2022-05-30T12:05:55Z

PS aws-sdk-php seems to be affected by PHPCompatibility/PHPCompatibility#1339

Zombaya · 2022-06-07T21:21:06Z

@stobrien89, I found the source of the failing unittest Aws\Test\CloudFront\SignerTest::testBadPrivateKeyPath(), fixed it in the latest commit and rebased everything on master once more.

Could you review this once more?

stobrien89 · 2022-06-07T21:46:18Z

Hi @Zombaya,

So sorry for the delayed response— I missed your last message. I'll take another look. Thanks again for your patience!

stobrien89 · 2022-06-09T20:59:49Z

src/Api/Serializer/JsonBody.php

@@ -29,7 +29,7 @@ public function __construct(Service $api)
    public static function getContentType(Service $service)
    {
        return 'application/x-amz-json-'
-            . number_format($service->getMetadata('jsonVersion'), 1);
+            . number_format(($version = $service->getMetadata('jsonVersion')) !== null ? $version : 0.0, 1);


Could you make this multiple lines?

tests/Polyfill/PHPUnit9/PHPUnitCompatTrait.php

stobrien89 · 2022-06-09T21:17:12Z

tests/bootstrap.php


-if (!class_exists('\PHPUnit\Framework\Constraint\RegularExpression')) {
+if ( ! defined('PHPUNIT_COMPOSER_INSTALL')) {


Can you change the not operator spacing in this file as well? i.e. (!class_exists...

tests/bootstrap.php

stobrien89 · 2022-06-09T21:19:19Z

tests/bootstrap.php

@@ -22,10 +26,13 @@ class_alias('\PHPUnit_Framework_Error_Warning', '\PHPUnit\Framework\Error\Warnin

 // Patch PHPUnit class for PHP 7.4+ and PHPUnit 5.x to avoid deprecation warning
 // Necessary because older versions of PHPUnit are no longer supported
-$version = PHPUnit_Runner_Version::id();
+$version     = class_exists('PHPUnit_Runner_Version') ? PHPUnit_Runner_Version::id() : PHPUnit\Runner\Version::id();


let's use standard spacing here as well.

src/S3/S3Client.php

SamRemis · 2022-06-09T21:22:47Z

tests/CloudFront/UrlSignerTest.php

        $this->assertStringStartsWith(
            "http://abc.cloudfront.net/images/image.jpg?color=red&Expires={$ts}&Signature=",
            $url
        );
        $urlObject = new Uri($url);
-        $query = \GuzzleHttp\Psr7\Query::parse($urlObject->getQuery());
+        $query     = \GuzzleHttp\Psr7\Query::parse($urlObject->getQuery());


I see a number of spaces like this one added that aren't really following our coding style; is this intentional? Was it just run through a linter?

I assume @27pchrisl either configured his IDE to do this automatically or has the same preference as me, which is aligned =-signs 🙂 .

I've removed it for now and reverted to what it was.

SamRemis · 2022-06-09T21:51:02Z

tests/EndpointParameterMiddlewareTest.php

@@ -90,7 +90,7 @@ public function testCorrectlyOutputsHost(
        });

        $handler = $list->resolve();
-        $handler($command, new Request('POST', $endpoint));
+        $handler($command, new Request('POST', $endpoint))->wait(false);


why was this change necessary?

This was done by @27pchrisl. I've unittested this with and without the wait() and was not able to find a reason why.

I've removed it again.

I found out why this was probably added.

When running this test using PHP 8.0 and PHPUnit 9.x, this test is marked as a risky test because it does not run any assertions. When adding ->wait(false), this disappears and the assertions are actually being done.

stobrien89

Left a few comments, but I think we're getting close :)

SamRemis · 2022-07-18T20:35:05Z

src/Api/Serializer/JsonBody.php

@@ -29,7 +29,12 @@ public function __construct(Service $api)
    public static function getContentType(Service $service)
    {
        return 'application/x-amz-json-'
-            . number_format($service->getMetadata('jsonVersion'), 1);
+            . number_format(


This will never be null. We have a check to ensure that every one of our services that go through this code will have a json version. For now, this is just a deprecated warning, right? We should consider just suppressing instead.

SamRemis · 2022-07-19T18:04:52Z

src/S3/S3Client.php

+            return false;
+        }
+
+        $bucketLen = $bucket !== null ? strlen($bucket) : 0;


This check is not necessary if we are checking for is_string above; it will never be null and always be a string, right?

SamRemis · 2022-07-19T18:16:15Z

tests/Polyfill/PHPUnit4/PHPUnitCompatTrait.php

@@ -0,0 +1,141 @@
+<?php
+


Is there a reason we would use our own Polyfill instead of taking a dependency on something widely tested and maintained like https://github.com/Yoast/PHPUnit-Polyfills?

Not at all, I will update this. I wasn’t sure what the AWS policy was on third party deps.

@SamRemis although, having just taken a look at it, it's quite a substantial change at this point, so just checking it's something you're definitely asking for :)

But worth noting that even if we pull polyfills from PHPUnit-Polyfills we'll still need some of our own, for example to handle readAttribute()

I'd think it's worth having as little code to maintain as possible by using the polyfill, especially when there's a dependency that does exactly that. I'd prefer it, yes. @stobrien89, do you agree?

Also as a side note, sorry this is taking so long. It's a huge PR and carefully looking at every single file over and over again is very time consuming. Thank you for being patient, and I'll do my best to prioritize it higher. If you don't see me respond for a bit, feel free to @ me to give me a notification. That said, I'll try to look at this every day until it's merged.

@SamRemis @27pchrisl,

I definitely agree. Especially with us looking forward to the next major version, having as little code to maintain as possible will be ideal. Thanks again for all of the work on this @Zombaya and @27pchrisl!

SamRemis · 2022-07-19T18:17:30Z

tests/CloudFront/UrlSignerTest.php

-        $ts = time() + 1000;
-        $key = $_SERVER['CF_PRIVATE_KEY'];
-        $kp = $_SERVER['CF_KEY_PAIR_ID'];
+        $ts     = time() + 1000;


SamRemis · 2022-07-19T18:18:04Z

tests/CloudFront/UrlSignerTest.php

-        $ts = time() + 1000;
-        $key = $_SERVER['CF_PRIVATE_KEY'];
-        $kp = $_SERVER['CF_KEY_PAIR_ID'];
+        $ts     = time() + 1000;


SamRemis · 2022-07-19T18:18:09Z

tests/CloudFront/UrlSignerTest.php


        $invalidUri = 'http://abc.cloudfront.net/images/éüàçµñåœŒ.jpg?query key=query value';
-        $uri = new Uri($invalidUri);
+        $uri        = new Uri($invalidUri);


SamRemis · 2022-07-19T18:18:31Z

tests/CloudFront/UrlSignerTest.php

-            'policy' => '{}',
-            'private_key' => $_SERVER['CF_PRIVATE_KEY'],
-            'key_pair_id' => $_SERVER['CF_KEY_PAIR_ID']
+        $url    = $client->getSignedUrl(array(


spacing (next three lines)

tests/ClientResolverTest.php

stobrien89 · 2022-07-21T20:33:50Z

@Zombaya, @27pchrisl,

I've rebased and updated tests for RemoveUnusedServices and #2459. I've also fixed some of the warnings/risky tests that appear in 7.3+ and addressed @SamRemis's most recent comments. I've attempted to push, but it looks like I'll need to be granted access. Thanks again!

Zombaya · 2022-07-25T07:56:12Z

@stobrien89 , I've added you and the other contributors here as contributor to the project so you should be able to push to the branch.

Otherwise a second PR can be created to replace this one from your branch.

RobinHoutevelts · 2022-08-04T08:23:36Z

@stobrien89 Did you manage to get the work you did above (#2403 (comment)) into this PR?

stobrien89 · 2022-08-04T21:03:16Z

Hi @Zombaya, @27pchrisl, @RobinHoutevelts,

Apologies for the delay. Just pushed up the changes I mentioned in my last comment, including some changes related to #2498.

From here, the next step would be to take a dependency on https://github.com/Yoast/PHPUnit-Polyfills. @SamRemis and I have discussed and with the next major version on the horizon, we'd rather not have another component to maintain. Thanks!

…dms/phpunit-arraysubset-asserts

…ionCount(1)

Zombaya · 2022-08-11T22:02:39Z

@stobrien89, @SamRemis, I've added a dependency on yoast/phpunit-polyfills and dms/phpunit-arraysubset-asserts.

dms/phpunit-arraysubset-asserts was added since the removed assertArraySubset-method is used in some places and is not provided by yoast/phpunit-polyfills. It is directly recommended by yoast/phpunit-polyfills though.

Strategy

Classes which use no deprecated PHPUnit-assertions extend PHPUnit\Framework\TestCase
Classes which use a deprecated PHPUnit-assertion provided by yoast/phpunit-polyfills extend Yoast\PHPUnitPolyfills\TestCases\TestCase
Traits which use deprecated PHPUnit-assertions use the specific Trait provided by yoast which provide the used assertion
Classes which use the deprecated method assertArraySubset() use the Trait provided by dms/phpunit-arraysubset-asserts

Base TestCase

I opted to only use Yoast\PHPUnitPolyfills\TestCases\TestCase as a base-class for testcases which actually use deprecated methods. I think this makes it more clear which testcases which are more interesting to refactor or to check in case the support for php 5.5 and PHPUnit 5 is dropped.

The other option would be that every test extends this TestCase. This way you do not need to be very aware of what methods are deprecated when writing new TestCases.

I felt that the first option was preferable.

Main changes

Different methodnames for setUp(), tearDown(), ...

The library by Yoast provides different methodnames for fixtures than what was used in the PhpUnitCompatTrait.

-- function _setUp() {}
++ function set_up() {}

-- function _tearDown() {}
++ function tear_down() {}

-- public static function _setUpBeforeClass()
++ public static function set_up_before_class()

-- public static function _tearDownAfterClass()
++ public static function tear_down_after_class()

$this->readAttribute() replaced by $this->getPropertyValue()

readAttribute() was part of PhpUnitCompatTrait. This has been replaced by the method provided by Yoast.

-- $this->assertArrayHasKey('s3', $this->readAttribute($p, 'manifest'));
++ $this->assertArrayHasKey('s3', $this->getPropertyValue($p, 'manifest'));

Replaced $this->expectNotToPerformAssertions() by $this->addToAssertionCount(1)

expectNotToPerformAssertions() does not exist in older versions of PHPUnit. It is also not provided by yoast/phpunit-polyfills.
That's why I opted to use $this->addToAssertionCount(1), to avoid problems with warnings of tests with no assertions.

I've left a comment in place to eventually replace it again with expectNotToPerformAssertions().

Other options would be writing a new compatibilityTrait inside our library, try to get a PR merged with yoast/phpunit-polyfills so that it provides the method or rewriting the tests so that they always do an assertion.

-- $this->expectNotToPerformAssertions();
++ $this->addToAssertionCount(1); // To be replaced with $this->expectNotToPerformAssertions();

I could not find a lot of documentation on the method. I couldn't find it in the docs for example. Some documentation I found:

…hecker

devicenull · 2022-09-07T19:31:12Z

Was any further progress made here? We've started to run into issues with PHP 8.1

RobinHoutevelts · 2022-09-08T14:11:20Z

Also as a side note, sorry this is taking so long. It's a huge PR and carefully looking at every single file over and over again is very time consuming. Thank you for being patient, and I'll do my best to prioritize it higher. If you don't see me respond for a bit, feel free to @ me to give me a notification. That said, I'll try to look at this every day until it's merged.

@SamRemis , consider this a friendly notification 👼

Thanks everyone for all the hard work so far!

SamRemis · 2022-09-08T23:17:09Z

@RobinHoutevelts thanks for the ping :) since the last update on Tuesday or Wednesday I've been working through this about 40 files a day, I'm gonna try to finish it up tomorrow or monday. Only issue I've found so far is a missing space, which I won't block on, so it's getting close :)

SamRemis · 2022-09-12T17:42:17Z

Just to update, I have about 20 files left to go through, which I won't be able to do before today's release, but I should be able to finish today. Assuming I find no issues, which I haven't yet in the first 140 files, I will be able to merge tonight and this should go out with tomorrow's release.

src/Api/Serializer/JsonBody.php

tests/ClientResolverTest.php

…patibility (#2403)" This reverts commit af584e7.

roborourke · 2022-09-13T13:35:01Z

Absolute legend @Zombaya

Zombaya · 2022-09-13T21:01:21Z

@SamRemis, @stobrien89, you made me one happy camper by getting this merged and released today!

Many thanks and much kudos for the effort you spent and the thorough review you did multiple times. I was impressed with the level of detail you went over everything, as well as the respectfulness of the notes when something was not quite correct.

Small shout-out to @27pchrisl for initiating the work on this PR and continuing to help after reviews have been made.

I think it's safe to say this was as PR me and a lot of others were all looking forward to be merged into master 🙂.

Zombaya marked this pull request as ready for review March 18, 2022 12:58

SamRemis reviewed Mar 21, 2022

View reviewed changes

stobrien89 mentioned this pull request Apr 5, 2022

PHP 8.0, 8.1, PHPUnit 9 support #2332

Closed

Zombaya force-pushed the phpcompatibilityChecker branch from e029b8f to ed1e252 Compare May 11, 2022 10:14

Zombaya commented May 11, 2022

View reviewed changes

Zombaya force-pushed the phpcompatibilityChecker branch from 3cf1c24 to 1e476ae Compare May 11, 2022 15:31

Zombaya commented May 12, 2022

View reviewed changes

stobrien89 requested changes May 16, 2022

View reviewed changes

Zombaya force-pushed the phpcompatibilityChecker branch from 1e476ae to 2ffe7cc Compare May 17, 2022 09:26

Zombaya force-pushed the phpcompatibilityChecker branch from 2ffe7cc to b0ab727 Compare June 7, 2022 21:15

Zombaya requested a review from stobrien89 June 7, 2022 21:21

stobrien89 reviewed Jun 9, 2022

View reviewed changes

tests/Polyfill/PHPUnit9/PHPUnitCompatTrait.php Outdated Show resolved Hide resolved

stobrien89 reviewed Jun 9, 2022

View reviewed changes

tests/bootstrap.php Outdated Show resolved Hide resolved

stobrien89 reviewed Jun 9, 2022

View reviewed changes

src/S3/S3Client.php Show resolved Hide resolved

SamRemis reviewed Jun 9, 2022

View reviewed changes

stobrien89 requested changes Jun 9, 2022

View reviewed changes

SamRemis reviewed Jul 19, 2022

View reviewed changes

update tests

b7b6f7e

refactor jsonbody getcontenttype

f49a0ef

Sean O'Brien and others added 4 commits August 4, 2022 14:37

add compattrait to endpointparametermiddlewaretest

ceb60cc

add compattrait to endpointparametermiddlewaretest

7ce24b4

add update to instanceprofileprovider

6d1e8aa

Merge branch 'master' into phpcompatibilityChecker

e98701e

Zombaya added 2 commits August 11, 2022 23:51

Replace PHPUnitCompatTrait with packages yoast/phpunit-polyfills and …

9634dfa

…dms/phpunit-arraysubset-asserts

Replace $this->expectNotToPerformAssertions() with $this->addToAssert…

661ac2f

…ionCount(1)

Zombaya force-pushed the phpcompatibilityChecker branch from 69a65c7 to 661ac2f Compare August 11, 2022 22:01

Merge remote-tracking branch 'upstream/master' into phpcompatibilityC…

4c34478

…hecker

driesvints mentioned this pull request Sep 8, 2022

Fix self callables #2518

Merged

stobrien89 added 2 commits September 12, 2022 14:26

fix spacing

e67a48e

Fix spacing

06e01bf

SamRemis approved these changes Sep 12, 2022

View reviewed changes

src/Api/Serializer/JsonBody.php Outdated Show resolved Hide resolved

tests/ClientResolverTest.php Show resolved Hide resolved

stobrien89 approved these changes Sep 12, 2022

View reviewed changes

SamRemis merged commit af584e7 into aws:master Sep 12, 2022

stobrien89 added a commit that referenced this pull request Sep 12, 2022

Revert "PHP 8.0, 8.1, PHPUnit 9 support + automated check for php com…

e9a6e5a

…patibility (#2403)" This reverts commit af584e7.

Zombaya mentioned this pull request Sep 13, 2022

Add PHP CS Fixer as a formatting tool and lint-stage during github CI #2521

Open


		if (!class_exists('\PHPUnit\Framework\Constraint\RegularExpression')) {
		if ( ! defined('PHPUNIT_COMPOSER_INSTALL')) {

PHP 8.0, 8.1, PHPUnit 9 support + automated check for php compatibility #2403

PHP 8.0, 8.1, PHPUnit 9 support + automated check for php compatibility #2403

Conversation

Zombaya commented Mar 18, 2022 • edited Loading

Zombaya commented Mar 18, 2022

stobrien89 commented Mar 18, 2022

Zombaya commented Mar 21, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stobrien89 commented May 10, 2022

Zombaya commented May 11, 2022 • edited Loading

Choose a reason for hiding this comment

Zombaya May 11, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zombaya commented May 11, 2022

Choose a reason for hiding this comment

allemas Jun 2, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zombaya commented May 17, 2022 • edited Loading

divinity76 commented May 30, 2022

Zombaya commented Jun 7, 2022

stobrien89 commented Jun 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stobrien89 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stobrien89 commented Jul 21, 2022

Zombaya commented Jul 25, 2022

RobinHoutevelts commented Aug 4, 2022

stobrien89 commented Aug 4, 2022 • edited Loading

Zombaya commented Aug 11, 2022 • edited Loading

Strategy

Base TestCase

Main changes

Different methodnames for setUp(), tearDown(), ...

$this->readAttribute() replaced by $this->getPropertyValue()

Replaced $this->expectNotToPerformAssertions() by $this->addToAssertionCount(1)

devicenull commented Sep 7, 2022

RobinHoutevelts commented Sep 8, 2022

SamRemis commented Sep 8, 2022

SamRemis commented Sep 12, 2022

roborourke commented Sep 13, 2022

Zombaya commented Sep 13, 2022

Zombaya commented Mar 18, 2022 •

edited

Loading

Zombaya commented May 11, 2022 •

edited

Loading

Zombaya May 11, 2022 •

edited

Loading

allemas Jun 2, 2022 •

edited

Loading

Zombaya commented May 17, 2022 •

edited

Loading

stobrien89 commented Aug 4, 2022 •

edited

Loading

Zombaya commented Aug 11, 2022 •

edited

Loading