fix: update AWS_S3_USE_ARN_REGION to take precedence over value set i… #3513
Conversation
|
|
||
| private bool forcePathStyle = false; | ||
| private bool useAccelerateEndpoint = false; | ||
| private S3UsEast1RegionalEndpointValue? s3UsEast1RegionalEndpointValue; | ||
| private readonly string legacyUSEast1GlobalRegionSystemName = RegionEndpoint.USEast1.SystemName; | ||
|
|
||
| private static CredentialProfileStoreChain credentialProfileChain = new CredentialProfileStoreChain(); | ||
| private static CredentialProfileStoreChain credentialProfileChain = new CredentialProfileStoreChain(Environment.GetEnvironmentVariable(AwsConfigFileEnvName)); |
There was a problem hiding this comment.
I'm open to leaving this as is. We added support for AWS_CONFIG_FILE a couple years ago and when this class was created, this environment variable wasn't available. Now that it is, it makes sense for the CredentialProfileStoreChain to check this value to see if it should look somewhere else for the config file.
Given that the constructor accepts a ProfileLocation, I thought it made sense to add it here. If it isn't set, then it will just continue to work as it did previously.
There was a problem hiding this comment.
I prefer changing this in a separate PR, since there are other configs that need to fixed:
There was a problem hiding this comment.
Okay, given there are other services that need the update, we can do it all in a separate pr👍
generator/.DevConfigs/83d75756-74fc-4a10-98a6-96c5c71bda8b.json
Outdated
Show resolved
Hide resolved
|
|
||
| private bool forcePathStyle = false; | ||
| private bool useAccelerateEndpoint = false; | ||
| private S3UsEast1RegionalEndpointValue? s3UsEast1RegionalEndpointValue; | ||
| private readonly string legacyUSEast1GlobalRegionSystemName = RegionEndpoint.USEast1.SystemName; | ||
|
|
||
| private static CredentialProfileStoreChain credentialProfileChain = new CredentialProfileStoreChain(); | ||
| private static CredentialProfileStoreChain credentialProfileChain = new CredentialProfileStoreChain(Environment.GetEnvironmentVariable(AwsConfigFileEnvName)); |
There was a problem hiding this comment.
I prefer changing this in a separate PR, since there are other configs that need to fixed:
peterrsongg
force-pushed
the
petesong/dotnet-7073
branch
from
73efa50
to
d75ea8d
Compare
…n config file
Description
This updates AmazonS3Config use-arn-region to take the value set in environment variable over that set in the ~/.aws/config file. This follows other env var + config file precedence.
Motivation and Context
dotnet-7073
Testing
dry run in v4 passes
Added unit tests
Screenshots (if appropriate)
Types of changes
Checklist
License