Support decimal precision for Document.FromJson and ToJson by using System.Text.Json instead of LitJson #3447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before
Currently,
Document.FromJson
andDocument.ToJson
in DynamoDBv2 use LitJson for JSON handling.This does not support
decimal
, as the first numeric type it matches to here isdouble
.aws-sdk-net/sdk/src/Core/ThirdParty/Json/JsonReader.cs
Lines 132 to 144 in c88243b
This is leading to a loss of precision for decimal values, see the linked issues.
After
This proposes to address this by replacing LitJson in these code paths with System.TextJson.
While this addresses the reported issue, we still need to look at:
Motivation and Context
#1555 , #1039
Testing
Types of changes
Checklist
License