fix: update redirect logic to also update path #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a 307 redirect comes in, it contains the new, full URL for the location change. The current logic respects this for the `Host` header that gets sent, but it does not then update the path, leading to possibly invalid redirects. The new logic pulls the path out of the endpoint and updates the outgoing request.
|
@AllanZhengYP Added the CHANGELOG entry following the contribution guidelines, please let me know if you need anything else. The commit name is weird because I did it through GitHub Dev online, so hopefully you can squash it before release. |
|
Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue. |
github-actions
bot
added
the
closing-soon
|
Please do not close. Internal issue that should be addressed. |
github-actions
bot
removed
the
closing-soon
kuhe
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a 307 redirect comes in, it contains the new, full URL for the location change.
The current logic respects this for the
Hostheader that gets sent, but it does notthen update the path, leading to possibly invalid redirects. The new logic pulls the
path out of the endpoint and updates the outgoing request.
Checklist
npm run testpassesRef: Ticket ID V544628989