Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update engines field for node to >= 10.0.0 #3933

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Update engines field for node to >= 10.0.0 #3933

merged 2 commits into from
Nov 1, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 27, 2021

This PR will be merged before the release on Monday 2021/11/01

Checklist
  • changelog is added, npm run add-change
  • non-code related change (markdown/git settings etc)

@trivikr trivikr marked this pull request as draft October 27, 2021 17:30
AllanZhengYP
AllanZhengYP approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!

@trivikr trivikr marked this pull request as ready for review November 1, 2021 13:06
@trivikr trivikr merged commit f5ffec7 into aws:master Nov 1, 2021
@trivikr trivikr deleted the update-engines-node-10 branch November 1, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivikr @AllanZhengYP