send empty object in body for requests other than GET #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2589 +/- ##
=======================================
Coverage 96.81% 96.81%
=======================================
Files 282 282
Lines 8550 8550
Branches 1623 1623
=======================================
Hits 8278 8278
Misses 272 272
Continue to review full report at Codecov.
|
|
|
AllanZhengYP
changed the title
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous change #2574 breaks the SDK when request the method is 'PUT' or 'POST' and request body is '{}'. SDK used to send the body but later ignored the body after the change. This PR fix the bug reported here #2588 .
Checklist
npm run testpassesnpm run add-change