Add credentialProvider as an optional parameter of ConfigurationOptions #1339
Conversation
As discussed in #1338 the documentation for AWS.S3 and AWS.SES both state that they accept credentialProvider, which is an instance of AWS.CredentialProviderChain, as part of the configuration options. However, the declaration for ConfigurationOptions did not expose such a parameter. This patch resolves that issue. Fixes #1338
| }; | ||
| var s3 = new AWS.S3(options); | ||
| var ses = new AWS.SES(options); |
There was a problem hiding this comment.
@chrisradek I am not exactly sure what the extent of the expected test should be. I feel like this covers the intent of what the change now provides. Obviously, if this is wrong I'll need a little bit more guidance on what to do next.
There was a problem hiding this comment.
@RLovelett
This should be fine. We really just want to make sure the code compiles correctly, and that we don't break it in the future. This captures the intent.
3 similar comments
There was a problem hiding this comment.
Can you also run npm run add-change.
I think this could be classified as a bugfix with TypeScript as the category.
| }; | ||
| var s3 = new AWS.S3(options); | ||
| var ses = new AWS.SES(options); |
There was a problem hiding this comment.
@RLovelett
This should be fine. We really just want to make sure the code compiles correctly, and that we don't break it in the future. This captures the intent.
|
@RLovelett |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
As discussed in #1338, the documentation for
AWS.S3andAWS.SESboth state that they acceptcredentialProvider, which is an instance ofAWS.CredentialProviderChain, as part of the configuration options.However, the declaration for
ConfigurationOptionsdid not expose such a parameter. This patch resolves that issue.Fixes #1338