-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NotImplemented - A header you provided implies functionality that is not implemented #15
Comments
I can't reproduce this error on my side. I am getting a successful result when I put an object with that set of values. The note about NotImplemented is valid, though. We don't (yet) have special rules for handling this error code-- the current logic is to simply retry 500 errors. This can be fixed. Can you provide any more data about how you are getting this error? Probably unhelpful would be your node version and aws-sdk version (log |
Another condition necessary for failure is multiple processes ( say
I can confirm that a manually triggered individual call succeeds. It's a somewhat arcane failure case. Those I will continue digging and try to provide more information. |
Seems like one of the headers is invalid, try printing the results of |
I'll keep looking. |
Ok, I have a contrast between successful and failed operations. Well, there's really no contrast, looks the same to me. The successful operation
failed operation
|
I have a hint. If Will verify shortly. |
That would be an easy fix if true-- but this might be a symptom of a larger problem. Is there a reason why your requests would have intermittent empty bodies? Or were some of the files being uploaded empty? |
Confirmed, Some files were being uploaded empty. Allowing uploading empty files is useful from the perspective of having a "log heartbeat" if you will. Say, I want to dump activity/log data into s3 at a set time interval. If I have no data, the presence of an empty file still lets me know that the reporting agent is still alive (i.e. heartbeat). |
Supporting empty files doesn't need justifying, I was just confirming that there was no other issue at play here. Thanks for looking into this and confirming, this is an easy fix, see: https://github.com/aws/aws-sdk-js/blob/master/lib/rest_xml_client.js#L69-L72 |
Thanks for getting to this, I was just about to commit my own-- there are some extra things to adjust in addition to that patch though, which I am dealing with now :) |
Ah, sorry for stepping on you :D . You're more familiar with the code base, so I'm sure I missed a bunch. Thanks! |
You only missed a minor change, actually. |
(pulling a valid body back out in the same scenario) |
Interesting, I'll have to take a look at what's going on there later on. Going offline. Thanks again, cheers! |
The failure scenario with that change is expressed in a test added in the commit prior to that one. The problem is raised if you make assumptions about the |
This can be closed, as it was fixed by #16. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
I am consistently receiving a
NotImplemented
error when trying to write a simple text file to S3 using the sdk.results in the following error:
which, in itself seems weird considering it is
NotImplemented
but isretryable
.The text was updated successfully, but these errors were encountered: