fix: exclude locationconstraint from s3 createBucket in us-east-1 (#4666

)
aws · Aug 14, 2024 · a1c0ff7 · a1c0ff7
1 parent 03debbd
commit a1c0ff7
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/.changes/next-release/bugfix-s3-9367ca5d.json b/.changes/next-release/bugfix-s3-9367ca5d.json
@@ -0,0 +1,5 @@
+{
+  "type": "bugfix",
+  "category": "s3",
+  "description": "omit locationConstraint in createBucket to us-east-1"
+}
diff --git a/lib/services/s3.js b/lib/services/s3.js
@@ -1263,7 +1263,11 @@ AWS.util.update(AWS.S3.prototype, {
     // mutate params object argument passed in by user
     var copiedParams = AWS.util.copy(params);
 
-    if (hostname !== this.api.globalEndpoint && !params.CreateBucketConfiguration) {
+    if (
+      this.config.region !== 'us-east-1'
+        && hostname !== this.api.globalEndpoint
+        && !params.CreateBucketConfiguration
+    ) {
       copiedParams.CreateBucketConfiguration = { LocationConstraint: this.config.region };
     }
     return this.makeRequest('createBucket', copiedParams, callback);

diff --git a/scripts/region-checker/allowlist.js b/scripts/region-checker/allowlist.js
@@ -50,7 +50,8 @@ var allowlist = {
         819,
         820,
         821,
-        826
+        826,
+        1266
     ],
     '/token/sso_token_provider.js': [
         60