Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(middleware-user-agent): ignore errors from inspecting credentials #6551

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix(middleware-user-agent): ignore errors from inspecting credentials #6551

merged 1 commit into from
Oct 8, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 8, 2024 •
edited
Loading

From the PR comment:

// Sometimes config.credentials is a function but only throws
// as a way of informing users that something is missing.
// That error and any other errors are not relevant for feature-checking
// and are ignored.

@kuhe kuhe requested a review from a team as a code owner October 8, 2024 17:36
@kuhe kuhe merged commit 4ddaa97 into aws:main Oct 8, 2024
2 of 4 checks passed
@kuhe kuhe deleted the fix/features branch October 8, 2024 17:44
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@siddsriv siddsriv siddsriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @siddsriv