Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): process commits since origin/main in test:e2e:legacy:preview #6539

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 3, 2024

Issue

Description

Processes commits since origin/HEAD in test:e2e:legacy:preview

Testing

Verified with changes post merging #6524 which impacts multiple clients

  • preview runs e2e tests only for the client being updated
  • since:release runs e2e tests for all clients changed since last release
# Create new branch
$ git checkout -b test 2990ea8f0d689966a9de0000d579f147c2d4af81

# Cherry pick commit from this PR
$ git cherry-pick 79d7dcebd0f9cb571410f34cbc3296d0a8ca658c

# Revert and cherry pick EC2 commit
$ git revert 7fad22475a7768262a35854a0b30ec5ba11a2d36
$ git cherry-pick 7fad22475a7768262a35854a0b30ec5ba11a2d36

# Revert and cherry pick update in endpoints
$ git revert cf0e4097a0342df9eea157c25398a78cef889747
$ git cherry-pick cf0e4097a0342df9eea157c25398a78cef889747

# The preview runs e2e test only for the last changed package, i.e. ec2
$ yarn test:e2e:legacy:preview
yarn run v1.22.22
$ ./tests/e2e-legacy/preview.mjs
Updated scope: client-ec2
Running cucumber test: 
node_modules/.bin/cucumber-js --fail-fast -t "@ec2"
......................

5 scenarios (5 passed)
12 steps (12 passed)
1m53.451s (executing steps: 1m53.402s)
Done in 114.71s.

# The since:release runs e2e test for all changed packages
$ yarn test:e2e:legacy:since:release
yarn run v1.22.22
$ ./tests/e2e-legacy/since-release.mjs
Looking for changed packages...
lerna notice cli v5.5.2
lerna info Looking for changed packages since v3.658.0
lerna success found 413 packages ready to publish
Running cucumber test: 
node_modules/.bin/cucumber-js --fail-fast -t "@acm or @cloudformation or @cloudfront or @cloudtrail or @cloudwatch or @codecommit or @codedeploy or @codepipeline or @dynamodb or @ec2 or @ecr or @ecs or @efs or @elasticache or @emr or @gamelift or @glacier or @iam or @inspector or @iot or @kinesis or @kms or @lambda or @pinpoint or @rds or @redshift or @s3 or @sagemaker or @ses or @sns or @sqs or @ssm or @sts or @swf or @waf or @workspaces"
..............................................................................................................................................................................................................................................................................................................................................................................................................................................Are you using a Stream of unknown length as the Body of a PutObject request? Consider using Upload instead from @aws-sdk/lib-storage.
...........................................................................................................................................................................................................

103 scenarios (103 passed)
359 steps (359 passed)
3m37.179s (executing steps: 3m36.412s)
Done in 228.02s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the preview-commits-since-origin-head branch from 4635467 to 79d7dce Compare October 3, 2024 04:00
@trivikr trivikr marked this pull request as ready for review October 3, 2024 04:00
@trivikr trivikr requested a review from a team as a code owner October 3, 2024 04:00
@trivikr trivikr changed the title fix(scripts): process commits since origin/HEAD in test:e2e:legacy:preview fix(scripts): process commits since origin/main in test:e2e:legacy:preview Oct 3, 2024
@trivikr trivikr merged commit 56b76f4 into aws:main Oct 3, 2024
2 checks passed
@trivikr trivikr deleted the preview-commits-since-origin-head branch October 3, 2024 14:20
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants