Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(polly-request-presigner): override middleware name to allow concurrent presigning #6335

Merged
merged 1 commit into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/polly-request-presigner/src/getSignedUrls.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,4 +98,18 @@ describe("getSignedUrl", () => {
expect(mockPresign).toBeCalled();
expect(mockPresign.mock.calls[0][1]).toMatchObject(options);
});
it("should not throw if called concurrently", async () => {
const mockPresigned = "a presigned url";
mockPresign.mockReturnValue(mockPresigned);
const client = new PollyClient(clientParams);
const command = new SynthesizeSpeechCommand({
Text: "hello world, this is alex",
OutputFormat: "mp3",
VoiceId: "Kimberly",
});
const result = await Promise.all([getSignedUrl(client, command), getSignedUrl(client, command)]);
expect(result).toBeInstanceOf(Array);
expect(result).toHaveLength(2);
expect(mockPresign).toHaveBeenCalledTimes(2);
});
});
1 change: 1 addition & 0 deletions packages/polly-request-presigner/src/getSignedUrls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export const getSignedUrl = async (
name: "presignInterceptMiddleware",
relation: "before",
toMiddleware: "awsAuthMiddleware",
override: true,
});

let presigned: HttpRequest;
Expand Down
Loading