Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add deprecation message for shapes #5902

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Mar 15, 2024

Issue

Internal JS-5074

Description

Add deprecation message for shapes

Testing

Before

Deprecation message is not shown

Screenshot

no-deprecation-message

After

Deprecation message is shown

Screenshot

deprecation-message

Additional context

ToDo: Update Smithy commit and regenerate clients on merging smithy-lang/smithy-typescript#1209


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review March 15, 2024 15:33
@trivikr trivikr requested a review from a team as a code owner March 15, 2024 15:33
@trivikr trivikr merged commit a967bfc into aws:main Mar 15, 2024
4 checks passed
@trivikr trivikr deleted the shapes-deprecation-message branch March 15, 2024 15:50
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants