Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependency check script and undeclared dependencies #5658

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jan 9, 2024

  • fix the dependency check script, a .slice(1) was omitting one of the matches that should have been checked.
  • then add any detected missing dependencies.

@kuhe kuhe requested review from a team as code owners January 9, 2024 19:22
@kuhe
Copy link
Contributor Author

kuhe commented Jan 9, 2024

fixes #5632

@kuhe kuhe merged commit 3c249d0 into aws:main Jan 9, 2024
3 checks passed
@kuhe kuhe deleted the fix/dependencies branch January 9, 2024 20:54
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants