feat: cjs inline build #5644
Merged
feat: cjs inline build #5644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
experiment/inliner
branch
from
7dc387d to
1647ede
Compare
This comment was marked as outdated.
This comment was marked as outdated.
kuhe
force-pushed
the
experiment/inliner
branch
from
1647ede to
b9a1209
Compare
|
#5653 should fix that error |
kuhe
force-pushed
the
experiment/inliner
branch
2 times, most recently
from
f3511c0 to
56620ee
Compare
siddsriv
approved these changes
Jan 9, 2024
syall
approved these changes
Jan 10, 2024
kuhe
force-pushed
the
experiment/inliner
branch
6 times, most recently
from
2bf85af to
72f97d5
Compare
kuhe
force-pushed
the
experiment/inliner
branch
from
72f97d5 to
d073880
Compare
RanVaknin
pushed a commit
to RanVaknin/aws-sdk-js-v3
that referenced
this pull request
Jan 16, 2024
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description
This is paired with the
index inliningfeature from smithy-lang/smithy-typescript#1113.Testing
manual testing
Checklist
n/aIf you wrote E2E tests, are they resilient to concurrent I/O?n/aIf adding new public functions, did you add the@publictag and enable doc generation on the package?