-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: codegen for command class builder #5604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kuhe
force-pushed
the
feat/commands
branch
3 times, most recently
from
December 21, 2023 19:28
b84f4ac
to
40804fb
Compare
kuhe
changed the title
feat: sample diff for command codegen helper
feat: codegen for command class builder
Dec 21, 2023
kuhe
force-pushed
the
feat/commands
branch
2 times, most recently
from
December 22, 2023 18:20
4fe3db9
to
f08d960
Compare
trivikr
approved these changes
Dec 22, 2023
siddsriv
approved these changes
Dec 22, 2023
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main description is in smithy-lang/smithy-typescript#1118
codegen diff for smithy-lang/smithy-typescript#1120